Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for detecting PhpStorm editor #717

Merged
merged 2 commits into from
May 20, 2022
Merged

Add support for detecting PhpStorm editor #717

merged 2 commits into from
May 20, 2022

Conversation

PadowYT2
Copy link

@PadowYT2 PadowYT2 commented May 20, 2022

Closes #716

Description

This only adds for snap, if you install it without snap (with an archive), it can be anywhere so yea.

Copy link
Owner

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @PadowYT2!

@shiftkey shiftkey changed the title Add PhpStorm Add support for detecting PhpStorm editor May 20, 2022
@shiftkey shiftkey merged commit 67af628 into shiftkey:linux May 20, 2022
@PadowYT2 PadowYT2 deleted the patch-1 branch May 20, 2022 14:23
@PadowYT2
Copy link
Author

Hey @shiftkey, as I need the pr to be in a release, is there a way I can build the package myself right now? If yes, how so?

@shiftkey
Copy link
Owner

To generate a local release you can try this:

yarn 
yarn build:prod
yarn run package

@AlejandroAkbal
Copy link

Thank you PadowYT2 <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PhpStorm Jetbrains is not visible
3 participants