Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch electron-installer-redhat to disable .build-id links in directory #837

Merged
merged 4 commits into from
Feb 26, 2023

Conversation

shiftkey
Copy link
Owner

Closes #796

Description

This works around the problem where multiple packages generate the same .build-id/ directory contents, by passing in the right argument to the electron-installer-redhat template.

Screenshots

Before:

$ rpm -qlp /srv/createrepo/GitHubDesktop-linux-3.1.7-linux1.rpm | grep .build-id
/usr/lib/.build-id
/usr/lib/.build-id/0c
/usr/lib/.build-id/0c/c0a6654ccba2233fe9ae923ec3b41fbff88ecf
/usr/lib/.build-id/25
/usr/lib/.build-id/25/ad28b19921d0ed63a7e404a29c712279297b41
/usr/lib/.build-id/32
/usr/lib/.build-id/32/dd851d017dce968296854d769ce2eff5c7b530
/usr/lib/.build-id/42
/usr/lib/.build-id/42/05ff88f87056d6a17255e362a8e13370ff7d5a
/usr/lib/.build-id/42/49e6911dafa4ae6641c876a0e3e2f42774868e
/usr/lib/.build-id/62
/usr/lib/.build-id/62/2d90bb8071e24058983873ec4af167a9e322fd
/usr/lib/.build-id/62/2d90bb8071e24058983873ec4af167a9e322fd.1
/usr/lib/.build-id/63
/usr/lib/.build-id/63/e217fb9027ae8d5a8d70bd647853da7daea90a
/usr/lib/.build-id/7a
/usr/lib/.build-id/7a/2da6ede698c92e9a2ef54b441ba17c60cee0b1
/usr/lib/.build-id/88
/usr/lib/.build-id/88/ad16bea9f62f77d82139e0722f27d311c7abee
/usr/lib/.build-id/8a
/usr/lib/.build-id/8a/f6b68b31ad9fd8aee38e4f1796a6d6ce71380e
/usr/lib/.build-id/8c
/usr/lib/.build-id/8c/1f5a43497013414e8e5affc41b54a1cfc91272
/usr/lib/.build-id/a2
/usr/lib/.build-id/a2/562c52725bb7caa27cd0de814ec368b8c45e7f
/usr/lib/.build-id/a5
/usr/lib/.build-id/a5/924fba24e3ec19cd288fb611d5662b38cb10db
/usr/lib/.build-id/a5/d78522a85bda84f552056496d8b2033003de50
/usr/lib/.build-id/ac
/usr/lib/.build-id/ac/fcf0f9ab97028910bbf224fadce67e8187aaf4
/usr/lib/.build-id/d1
/usr/lib/.build-id/d1/ad5fe2127add07286cfca1f9ccc7e79df037e3
/usr/lib/.build-id/d1/ad5fe2127add07286cfca1f9ccc7e79df037e3.1
/usr/lib/.build-id/da
/usr/lib/.build-id/da/fd4e0728b3453ee89d124aad0501a4dc5b02d0
/usr/lib/.build-id/e7
/usr/lib/.build-id/e7/21f91f7ae8b76bd365648be789d24b337222bc
/usr/lib/.build-id/ee
/usr/lib/.build-id/ee/c35af598d97b68ccecf96f783924c7f3ebc3fb

After: no files present

$ rpm -qlp dist/GitHubDesktop-linux-3.1.7.rpm| grep .build-id

@shiftkey shiftkey marked this pull request as ready for review February 20, 2023 20:46
@shiftkey shiftkey changed the title Manually patch redhat installer patch electron-installer-redhat to disable .build-id links in directory Feb 20, 2023
@shiftkey shiftkey marked this pull request as draft February 20, 2023 20:51
@shiftkey shiftkey marked this pull request as ready for review February 26, 2023 14:35
@shiftkey shiftkey merged commit 3f614de into linux Feb 26, 2023
@shiftkey shiftkey deleted the manually-patch-redhat-installer branch February 26, 2023 14:36
shiftkey added a commit that referenced this pull request Feb 26, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Feb 26, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Feb 26, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Mar 1, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Mar 1, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Mar 1, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Mar 2, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Mar 15, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Apr 4, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Apr 7, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Apr 7, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Apr 7, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
@theofficialgman
Copy link

I am currently getting errors with this change implemented on armhf linux. Any ideas what they mean?

error /home/ubuntu/desktop/node_modules/postinstall-postinstall: Command failed.
Exit code: 1
Command: node ./run.js
Arguments: 
Directory: /home/ubuntu/desktop/node_modules/postinstall-postinstall
Output:
error Command failed with exit code 2.
error Command failed with exit code 2.
node:child_process:935
    throw err;
    ^

Error: Command failed: yarn run postinstall
error Command failed with exit code 2.
error Command failed with exit code 2.

    at checkExecSyncError (node:child_process:861:11)
    at execSync (node:child_process:932:15)
    at Object.<anonymous> (/home/ubuntu/desktop/node_modules/postinstall-postinstall/run.js:15:5)
    at Module._compile (node:internal/modules/cjs/loader:1155:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
    at Module.load (node:internal/modules/cjs/loader:1033:32)
    at Function.Module._load (node:internal/modules/cjs/loader:868:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:22:47 {
  status: 2,
  signal: null,
  output: [
    null,
    Buffer(501) [Uint8Array] [
      121,  97, 114, 110,  32, 114, 117, 110,  32, 118,  49,  46,
       50,  49,  46,  49,  10,  36,  32, 116, 115,  45, 110, 111,
      100, 101,  32,  45,  80,  32, 115,  99, 114, 105, 112, 116,
       47, 116, 115,  99, 111, 110, 102, 105, 103,  46, 106, 115,
      111, 110,  32, 115,  99, 114, 105, 112, 116,  47, 112, 111,
      115, 116,  45, 105, 110, 115, 116,  97, 108, 108,  46, 116,
      115,  10,  91,  49,  47,  52,  93,  32,  82, 101, 115, 111,
      108, 118, 105, 110, 103,  32, 112,  97,  99, 107,  97, 103,
      101, 115,  46,  46,
      ... 401 more items
    ],
    Buffer(78) [Uint8Array] [
      101, 114, 114, 111, 114,  32,  67, 111, 109, 109,  97, 110,
      100,  32, 102,  97, 105, 108, 101, 100,  32, 119, 105, 116,
      104,  32, 101, 120, 105, 116,  32,  99, 111, 100, 101,  32,
       50,  46,  10, 101, 114, 114, 111, 114,  32,  67, 111, 109,
      109,  97, 110, 100,  32, 102,  97, 105, 108, 101, 100,  32,
      119, 105, 116, 104,  32, 101, 120, 105, 116,  32,  99, 111,
      100, 101,  32,  50,  46,  10
    ]
  ],
  pid: 9217,
  stdout: Buffer(501) [Uint8Array] [
    121,  97, 114, 110,  32, 114, 117, 110,  32, 118,  49,  46,
     50,  49,  46,  49,  10,  36,  32, 116, 115,  45, 110, 111,
    100, 101,  32,  45,  80,  32, 115,  99, 114, 105, 112, 116,
     47, 116, 115,  99, 111, 110, 102, 105, 103,  46, 106, 115,
    111, 110,  32, 115,  99, 114, 105, 112, 116,  47, 112, 111,
    115, 116,  45, 105, 110, 115, 116,  97, 108, 108,  46, 116,
    115,  10,  91,  49,  47,  52,  93,  32,  82, 101, 115, 111,
    108, 118, 105, 110, 103,  32, 112,  97,  99, 107,  97, 103,
    101, 115,  46,  46,
    ... 401 more items
  ],
  stderr: Buffer(78) [Uint8Array] [
    101, 114, 114, 111, 114,  32,  67, 111, 109, 109,  97, 110,
    100,  32, 102,  97, 105, 108, 101, 100,  32, 119, 105, 116,
    104,  32, 101, 120, 105, 116,  32,  99, 111, 100, 101,  32,
     50,  46,  10, 101, 114, 114, 111, 114,  32,  67, 111, 109,
    109,  97, 110, 100,  32, 102,  97, 105, 108, 101, 100,  32,
    119, 105, 116, 104,  32, 101, 120, 105, 116,  32,  99, 111,
    100, 101,  32,  50,  46,  10
  ]

theofficialgman pushed a commit to theofficialgman/desktop that referenced this pull request Jun 4, 2023
…ectory (shiftkey#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Jun 5, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Jun 5, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Jul 3, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Jul 3, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Jul 3, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Jul 3, 2023
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Jul 1, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Jul 13, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 10, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 10, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 10, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
…ectory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
patch `electron-installer-redhat` to disable `.build-id` links in directory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
patch `electron-installer-redhat` to disable `.build-id` links in directory (#837)

* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 11, 2024
* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 12, 2024
* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 14, 2024
* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 15, 2024
* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 17, 2024
* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Aug 17, 2024
* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Sep 2, 2024
* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
shiftkey added a commit that referenced this pull request Sep 2, 2024
* add patch-package so we can patch a node_modules package

* generate patch to disable build-id contents for RPM package

* move patch-package command to post-install script

* regenerate patch file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict with mailspring while installing Github Desktop
2 participants