Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multi-platform builds for BuildKit sample build strategy #1007

Conversation

SaschaSchwarze0
Copy link
Member

Changes

Adding the platforms parameter to the BuildKit sample build strategy to support multi-platform builds.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

The BuildKit sample build strategy now supports a `platforms` parameter to enable multi-platform builds

@SaschaSchwarze0 SaschaSchwarze0 added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 25, 2022
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Feb 25, 2022
@gabemontero
Copy link
Member

/approve

@gabemontero
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Feb 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit d50bf5d into shipwright-io:main Feb 28, 2022
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-buildkit-multi-platform branch March 4, 2022 20:13
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.9.0 milestone Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants