-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image blocks and blurring? (samples/simple-sphere.rb) #1309
Comments
Not sure, there was some block form we said we're not gonna do... can't remember if it was image do or shape do. |
Yeah I recall the shape form too. Don't need a call right now but if we aren't doing it that same, cool as it is, should go. |
So looked into this from a couple different angles and haven't come to any satisfying conclusions:
So where's that leave us? I hate to leave something plainly incompatible, but this seems over the effort line to me. Given that, I'd propose to leave these lying for now (maybe bump this issue to 4.1 for later consideration if someone wants), but plumb in stub methods that warn about the lack of support. This keeps Shoes 3 apps that used that from crashing (which is a bad experience), but avoids sinking too much time and energy there now. What do you think @PragTob? |
Sounds reasonable to me and I agree a lot - rather have a version out that is 95 to 99% compatible than quibble with the difficult stuff too long. 👍 |
Running through "bad" samples, and noticed that
samples/simple-sphere.rb
isn't close to running. It uses two big things that look problematic:image
form that takes a block instead of pointing to a fileblur
method which influences the drawingIf SWT doesn't easily support
blur
, may consider just dropping support for it (or marking with a warning and not implementing?) Bears more research.Image of app on Shoes 3:
The text was updated successfully, but these errors were encountered: