Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image blocks and blurring? (samples/simple-sphere.rb) #1309

Open
jasonrclark opened this issue Nov 26, 2016 · 4 comments
Open

Image blocks and blurring? (samples/simple-sphere.rb) #1309

jasonrclark opened this issue Nov 26, 2016 · 4 comments

Comments

@jasonrclark
Copy link
Member

Running through "bad" samples, and noticed that samples/simple-sphere.rb isn't close to running. It uses two big things that look problematic:

  • image form that takes a block instead of pointing to a file
  • blur method which influences the drawing

If SWT doesn't easily support blur, may consider just dropping support for it (or marking with a warning and not implementing?) Bears more research.

Image of app on Shoes 3:
image

@PragTob
Copy link
Member

PragTob commented Nov 27, 2016

Not sure, there was some block form we said we're not gonna do... can't remember if it was image do or shape do.

@jasonrclark
Copy link
Member Author

Yeah I recall the shape form too. Don't need a call right now but if we aren't doing it that same, cool as it is, should go.

@jasonrclark jasonrclark modified the milestones: 4.0.0.rc1, 4.0.0.pre9 Jan 25, 2017
@jasonrclark
Copy link
Member Author

So looked into this from a couple different angles and haven't come to any satisfying conclusions:

  1. There isn't an easy way to apply a blur effect that I can find in SWT. While certainly do-able with enough effort, it feels way out of proportion to my willingness to invest in it
  2. Looking over shoes3 source, found there was also glow as another effect. Wonder if there are others :/
  3. As far as image with block, it seems to share some similarity with shape--the basic art elements work within the block for both. image in Shoes 3 has blur/glow but doesn't support the positional line_to style methods. On the flip side, shape doesn't support blur/glow from what I can tell (behavior's odd, but doesn't seem to work).

So where's that leave us? I hate to leave something plainly incompatible, but this seems over the effort line to me. Given that, I'd propose to leave these lying for now (maybe bump this issue to 4.1 for later consideration if someone wants), but plumb in stub methods that warn about the lack of support. This keeps Shoes 3 apps that used that from crashing (which is a bad experience), but avoids sinking too much time and energy there now.

What do you think @PragTob?

@PragTob
Copy link
Member

PragTob commented Feb 4, 2017

Sounds reasonable to me and I agree a lot - rather have a version out that is 95 to 99% compatible than quibble with the difficult stuff too long. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants