Better failure on unsupported block form of image #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrclark
force-pushed
the
fail-image-block
branch
from
4796e19
to
1068b82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the stopgap to behave a little kinder around #1309 which we aren't addressing in the 4.0 release.
This raises the same
Shoes::NotImplementedErrorwe used for video, with a similar informative message.Also moves the specs over to the in-element-spec form for checking DSL.
Additionally, makes the parameter checking slightly looser on
imageso if we get block-form calls that have coordinates (which used to be supported), we can catch them with the block warning instead of a plainArgumentError.