Rubocop offences #1054
Closed
Rubocop offences #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 11, 2015 15:11
| else | ||
| nil | ||
| end | ||
| start_exists = element_start && parent && parent.element_start |
There was a problem hiding this comment.
instead of the local variable start_exists I'd rather have a little private method start_exists? - would make this even neater (imo) :)
|
Hi thanks for this 👍 Sorry about the failed build, that's my fault :( Will fix soon. I made 2 minor remarks, after that this is ready to be merged - I'll probably squash it before as the changes fit together rather nicely. Thanks so much for contributing to shoes! :) |
|
@PragTob you're welcome. Definitely squash them all :) |
|
Committed as 2ca7adf - thanks a ton 👍 ❤️ :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some rubocop offences that I've worked on for the issue #945 .