Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed samplexx.rb files appropriately (Issue #353). #1246

Merged
merged 2 commits into from
Sep 12, 2016

Conversation

rodenmonte
Copy link

Fixed minor Rubocop Issues (Issue #945)

@rodenmonte
Copy link
Author

rodenmonte commented Sep 10, 2016

"rubocop-0.42.0 requires ruby version >= 2.0.0, which is incompatible with the current version, ruby 1.9.3p551 (jruby 1.7.25)"

This error message occurs on the two checks that failed in the Travis CI build: 2762.7 and 2762.8. Maybe rubocop is not compatible with the older versions of ruby supported by Shoes4 (1.9.3p551 jruby1.7.25). Perhaps we should eliminate back-compatibility to 1.9.x? Maybe its a problem with Travis CI? Maybe something went wrong when I ran git clone or when I committed? I didn't change anything that would effect which version of ruby/rubocop runs.

@icon.move x.to_i, y.to_i
img.move x.to_i, y.to_i
end
pause = n
end
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me that you accidentally overrode somple-bounce.rb with some other sample?

@PragTob
Copy link
Member

PragTob commented Sep 11, 2016

First thanks for the PR @rodenmonte !

You did nothing wrong, shoes has been a bit idle and in the meantime new rubocop versions were released, Travis picked that up installed a new version and there was a deprecation. So it's our thing to fix :D

Looks good overall, thanks for making the PR and naming the samples. From my point of view there is 2 issues here left to be resolved:

  • simple-bounce.rb seemed to have been overridden - would be cool if you could restore the vintage version and rename the other (or tell me what I missed :) )
  • fix the build, which is more my thing to do on master

@PragTob
Copy link
Member

PragTob commented Sep 12, 2016

Trusting this works now that .travis.yml is adjusted on master, thanks :)

@PragTob PragTob merged commit 3d8d278 into shoes:master Sep 12, 2016
@rodenmonte rodenmonte deleted the feature/curate-samples branch September 12, 2016 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants