Rubocop: Your move, Creep

[jaredmoody]

Low hanging rubocop fixes for #945

I’m not 100% sure on the Lint/EmptyWhen fix if someone can double check that, I’d appreciate it.

[PragTob]

This seems to break the tests, cause Learning is a module not a class :)

[jaredmoody]

Thanks :P

[PragTob]

TBH this seems wrong?! o_O Imo it should be Empty === e if we wanted to literally translate the case statement to an if. I'd be shocked to find such a big bug in rubocop though.

[jaredmoody]

Rubocop was complaining about the empty when, but I made the change here - we're through all the auto-correctable cops now. I wasn't sure about this change though, so I mentioned it in the PR comments. Thanks for catching that I should have used ===. How do you want this to look though, would this be better?

@line = "" unless [Empty, Continue].include?(e.class)

[PragTob]

I think we really need an is_a? check to work with subclassing but yes something else would be better than currently :)

[PragTob]

LGTM in general, there is the test failure and the (imo) wrong conversion of the empty when conversion...

[PragTob]

👍

[PragTob]

wow that was ugly :D

[PragTob]

Rubocop bumms out...

samples/expert-irb-adjusted.rb:47:25: C: Avoid the use of the case equality operator ===.

    @line = "" unless e === Empty || e === Continue

                        ^^^

samples/expert-irb-adjusted.rb:47:40: C: Avoid the use of the case equality operator ===.

    @line = "" unless e === Empty || e === Continue

                                       ^^^

samples/expert-irb.rb:47:25: C: Avoid the use of the case equality operator ===.

    @line = "" unless e === Empty || e === Continue

                        ^^^

samples/expert-irb.rb:47:40: C: Avoid the use of the case equality operator ===.

    @line = "" unless e === Empty || e === Continue

                                       ^^^

I guess we could substitute it through an e.is_a?(clazz)

[jaredmoody]

OK, used is_a? to fix up that exception comparison and fixed that module definition.

[PragTob]

Thank you!