Throw a video not implementedm error upon calling that method #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks :) |
PragTob
added a commit
that referenced
this pull request
Jul 2, 2014
Throw a video not implementedm error upon calling that method
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #774 :)
So right now this is straight on the DSL level (impl and specs)... This isn't exactly future proof as what is implemented and what is not is a matter of the backend. So technically the error should be thrown upon instantiation of the appropriate backend object. However that makes it a bit harder to follow.. e.g. when you look at the code starting at DSL it's "Oh right the DSL object is created let's have a look there... oh cool it creates a backend object great... whooops that throws a NotImplementedError''
Open to changing that but looking for feedback :)
Tobi