Skip to content

Commit

Permalink
Update dependencies (#186)
Browse files Browse the repository at this point in the history 
* Update dependencies

* Bump Rust to 1.34
  • Loading branch information
@kornelski @shssoichiro
kornelski authored and shssoichiro committed Aug 4, 2019
1 parent 4adcc5e commit 239ca81
Show file tree
Hide file tree
Showing 5 changed files with 85 additions and 83 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ matrix:
env: TARGET=x86_64-apple-darwin
cache: cargo
- os: linux
rust: 1.31.0
rust: 1.34.0
env: TARGET=x86_64-unknown-linux-gnu
cache: cargo
- os: linux
Expand Down
Loading

2 comments on commit 239ca81

@RReverser
Copy link
Contributor

@RReverser RReverser commented on 239ca81 Mar 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just been bisecting unrelated issue, and noticed that this commit slightly degraded compression ratios for some images, e.g.:

Command:

cargo run -- -o 6 -P tests/files/grayscale_alpha_16_reduce_alpha_right.png --alpha

Before:

Processing: tests/files/grayscale_alpha_16_reduce_alpha_right.png
    200x152 pixels, PNG format
    2x16 bits/pixel, GrayscaleAlpha
    IDAT size = 32322 bytes
    File size = 32400 bytes
Trying: 216 combinations
Found better combination:
    zc = 9  zs = 1  f = 5        20295 bytes
    IDAT size = 20295 bytes (12027 bytes decrease)
    file size = 20373 bytes (12027 bytes = 37.12% decrease)
Running in pretend mode, no output

After:

Processing: tests/files/grayscale_alpha_16_reduce_alpha_right.png
    200x152 pixels, PNG format
    2x16 bits/pixel, GrayscaleAlpha
    IDAT size = 32322 bytes
    File size = 32400 bytes
Trying: 216 combinations
Found better combination:
    zc = 9  zs = 1  f = 5        20335 bytes
    IDAT size = 20335 bytes (11987 bytes decrease)
    file size = 20413 bytes (11987 bytes = 37.00% decrease)
Running in pretend mode, no output

It seems that cloudflare-zlib, which is responsible for compression here, hasn't changed, so what could affect the ratios instead? (UPD: I supose png upgrade could add some new metadata?)

Not sure if such a small difference is worth investigation, but posting just in case there is some low-hanging fruit.

@RReverser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually a bit worse: looks like on master these results still reproduce, but they're not deterministic. I'm getting 20335 bytes and 20295 bytes interchangeably between different runs.

Please sign in to comment.