Skip to content

Commit

Permalink
Remove default value for interlace to ensure it is kept when nx is us…
Browse files Browse the repository at this point in the history
…ed (#620)

Fixes #619.

Interlacing still defaults to 0 when `--nx` is not specified and can
still be explicitly set even if it is (e.g. `-i 0 --nx` will still
deinterlace).
  • Loading branch information
andrews05 committed Jun 2, 2024
1 parent 290bf9d commit e2c5b45
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,9 @@ transformation and may be unsuitable for some applications.")
.action(ArgAction::SetTrue),
)
.arg(
// Note: The default value is not explicitly set here, as it is dependant on the `--nx` flag.
Arg::new("interlace")
.help("Set PNG interlacing type (0, 1, keep)")
.help("Set PNG interlacing type (0, 1, keep) [default: 0]")
.long_help("\
Set the PNG interlacing type, where <type> is one of:
Expand All @@ -181,11 +182,12 @@ Set the PNG interlacing type, where <type> is one of:
keep => Keep the existing interlacing type of each image
Note that interlacing can add 25-50% to the size of an optimized image. Only use it if you \
believe the benefits outweigh the costs for your use case.")
believe the benefits outweigh the costs for your use case.
[default: 0]")
.short('i')
.long("interlace")
.value_name("type")
.default_value("0")
.value_parser(["0", "1", "keep"])
.hide_possible_values(true),
)
Expand Down

0 comments on commit e2c5b45

Please sign in to comment.