Restore executable permissions on Unix release tarball binaries #577
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrews05
approved these changes
Nov 15, 2023
These changes resolve #575 by setting the OxiPNG binary that's about to be put in a release tarball to be world-executable during the release workflow, as such permissions are lost when fetching them from artifacts.
AlexTMjugador
force-pushed
the
fix/missing-release-binary-execute-perms
branch
from
bc60309
to
15ecc9e
Compare
|
Alright, merging this! 🚀 |
Pr0methean
pushed a commit
to Pr0methean/oxipng
that referenced
this pull request
Dec 1, 2023
…oichiro#577) These changes resolve shssoichiro#575 by setting the OxiPNG binary that's about to be put in a release tarball to be world-executable during the release workflow, as such permissions are lost when fetching them from artifacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes resolve #575 by setting the OxiPNG binary that's about to be put in a release tarball to be world-executable during the release workflow, as such permissions are lost when fetching them from artifacts.