Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --keep display equivalent to --strip safe #584

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Add --keep display equivalent to --strip safe #584

merged 4 commits into from
Dec 13, 2023

Conversation

andrews05
Copy link
Collaborator

@andrews05 andrews05 commented Nov 30, 2023 •
edited
Loading

This PR reverts #580 and introduces --keep display instead.

See discussion in #581.

AlexTMjugador
AlexTMjugador reviewed Dec 10, 2023
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
AlexTMjugador
AlexTMjugador approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@AlexTMjugador AlexTMjugador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AlexTMjugador AlexTMjugador merged commit 63efc76 into shssoichiro:master Dec 13, 2023
10 checks passed
@andrews05 andrews05 deleted the feature/keep branch December 24, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTMjugador AlexTMjugador AlexTMjugador approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrews05 @AlexTMjugador