Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that no metadata is stripped by default #608

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

tobbez
Copy link
Contributor

@tobbez tobbez commented Apr 16, 2024

No description provided.

@andrews05
Copy link
Collaborator

andrews05 commented Apr 16, 2024

Hi @tobbez, thanks for the PR.

This sounds good, except none isn't actually a real option for --strip. If you pass --strip none it will actually attempt to strip chunks of type none.

If you think it would be helpful, perhaps this a feature you would like to add? Alternatively, since we don't really need a dedicated none option, we could just update the help text to make it clear that no stripping is performed by default?

@tobbez
Copy link
Contributor Author

tobbez commented Apr 17, 2024

I don't think a dedicated option to disable stripping is needed (unless a preset that turns stripping on is expected to be added in the future).

That doesn't seem particularly likely, and in that case it would be better to just update the documentation instead, as you suggested (just pushed such a change).

@tobbez tobbez changed the title Document --strip none Document that no metadata is stripped by default Apr 17, 2024
Copy link
Collaborator

@andrews05 andrews05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

And you're correct, there's no plans to ever do stripping by default.

@andrews05 andrews05 merged commit a70e523 into shssoichiro:master Apr 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants