Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hovering effect to Social media icons. #213

Merged
merged 4 commits into from
May 26, 2023

Conversation

SakshiRawat13
Copy link
Contributor

Related Issues

Solved the issue #209

Changes Proposed

Added hovering effect to social media icons.

Checklist

  • [🗸] I have read and followed the Contribution Guidelines.
  • [🗸] All new and existing tests passed.
  • [🗸] I have updated the documentation to reflect the changes I've made.
  • [🗸] My code follows the code style of this project.
  • [🗸] The title of my pull request is a short description of the requested changes.

Screenshots

final.recording.2023.mp4

@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 1:00pm

@shyamtawli
Copy link
Owner

@SakshiRawat13 Nice work, but please align the logos properly. There are spaces above and on the left side of the logo containers.
ssss

@shyamtawli shyamtawli added enhancement New feature or request changes-requested labels May 25, 2023
@SakshiRawat13
Copy link
Contributor Author

SakshiRawat13 commented May 25, 2023

@shyamtawli I have made the requested changes, Please can you review it. Thanks

Recording.2023-05-25.mp4

@SakshiRawat13 SakshiRawat13 changed the title Added hovering effect to Social media icons. Added hovering effect to Social media icons. // also made the required changes May 26, 2023
@shyamtawli shyamtawli changed the title Added hovering effect to Social media icons. // also made the required changes Added hovering effect to Social media icons. May 26, 2023
@shyamtawli
Copy link
Owner

@SakshiRawat13 Nice Work, Icons are looking amazing now.

Thank you for your contribution, and we look forward to working together to make our project even better. Don't forget to share and star the repo :)

@shyamtawli shyamtawli merged commit cefba48 into shyamtawli:master May 26, 2023
bharathkalyans pushed a commit to bharathkalyans/devFind that referenced this pull request May 26, 2023
* Added hovering effect to Social media icons

* made the required changes in the top and left margin

---------

Co-authored-by: Shyam Tawli <104145978+shyamtawli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants