fix: using async void Task is more appropriate

sidestep-labs · Aug 2, 2024 · 7ef7ea0 · 7ef7ea0
1 parent ea13041
commit 7ef7ea0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/KeyVaultExplorer/App.axaml.cs b/KeyVaultExplorer/App.axaml.cs
@@ -35,9 +35,9 @@ public static void CreateDesktopResources()
         if (!dbPassExists)
             DatabaseEncryptedPasswordManager.SetSecret($"keyvaultexplorer_{System.Guid.NewGuid().ToString()[..6]}");
 
-        Dispatcher.UIThread.Post(() =>
+        Dispatcher.UIThread.Post(async () =>
         {
-            KvExplorerDb.OpenSqlConnection();
+            await KvExplorerDb.OpenSqlConnection();
 
             if (!dbExists)
                 KvExplorerDb.InitializeDatabase();

diff --git a/KeyVaultExplorer/Database/KvExplorerDb.cs b/KeyVaultExplorer/Database/KvExplorerDb.cs
@@ -21,7 +21,7 @@ public KvExplorerDb()
     {
     }
 
-    public static async void OpenSqlConnection()
+    public static async Task OpenSqlConnection()
     {
         string DataSource = Path.Combine(Constants.DatabaseFilePath);
         var pass =  await DatabaseEncryptedPasswordManager.GetSecret();

diff --git a/KeyVaultExplorer/ViewModels/CreateNewSecretVersionViewModel.cs b/KeyVaultExplorer/ViewModels/CreateNewSecretVersionViewModel.cs
@@ -21,7 +21,7 @@ namespace KeyVaultExplorer.ViewModels;
 public partial class CreateNewSecretVersionViewModel : ViewModelBase
 {
     [ObservableProperty]
-    public List<KvResourceGroupModel> resourceGroupItems;
+    private List<KvResourceGroupModel> resourceGroupItems;
 
     private readonly AuthService _authService;
 
@@ -124,7 +124,7 @@ public async Task<ObservableCollection<SubscriptionDataItem>> GetAvailableSubscr
     }
 
     [RelayCommand]
-    public async Task NewVersion()
+    private async Task NewVersion()
     {
         var newSecret = new KeyVaultSecret(SecretName ?? KeyVaultSecretModel.Name, SecretValue);
         if (KeyVaultSecretModel.NotBefore.HasValue)
@@ -153,7 +153,7 @@ partial void OnKeyVaultSecretModelChanging(SecretProperties value)
 
 
     [RelayCommand]
-    public void SelectedSubscriptionChanged(SubscriptionDataItem value)
+    private void SelectedSubscriptionChanged(SubscriptionDataItem value)
     {
         if (value is not null && !_seenSubscriptions.Contains(value.Data.SubscriptionId))
         {