Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typescript PoolConnection error #1853

Closed
wants to merge 23 commits into from
Closed

Fix typescript PoolConnection error #1853

wants to merge 23 commits into from

Conversation

marlonfsolis
Copy link

Fixing TypeScript error TS2320: Interface 'PoolConnection' cannot simultaneously extend types 'PoolConnection' and 'Connection'.

@marlonfsolis
Copy link
Author

marlonfsolis commented Feb 21, 2023 •
edited
Loading

This fix is for open issues:

@sidorares
Copy link
Owner

Thanks a lot @marlonfsolis , the fix looks good!
Couple of notes:

  • would it be possible to add super simple typings smoke test? A ts script that currently fails type checks without your changes and produces no errors with
  • could you please rebase & rewrite commit messages to follow https://www.conventionalcommits.org/en/v1.0.0/ ? ( this is important for release-please to automatically prepare release PR and also github release and changelog )

marlonfsolis and others added 18 commits February 25, 2023 13:04
@marlonfsolis
Merge branch 'sidorares:master' into fix_typescript_poolconnection
bd03640
@marlonfsolis
test(Pool): typing test for PoolConnection interface
21356b9
@marlonfsolis
Merge remote-tracking branch 'origin/fix_typescript_poolconnection' i…
8a8005e 
…nto fix_typescript_poolconnection
@dependabot @marlonfsolis
build(deps-dev): bump c8 from 7.12.0 to 7.13.0
8da3799 
Bumps [c8](https://github.com/bcoe/c8) from 7.12.0 to 7.13.0.
- [Release notes](https://github.com/bcoe/c8/releases)
- [Changelog](https://github.com/bcoe/c8/blob/main/CHANGELOG.md)
- [Commits](bcoe/c8@v7.12.0...v7.13.0)

---
updated-dependencies:
- dependency-name: c8
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @marlonfsolis
build(deps): bump lru-cache from 7.15.0 to 7.16.0
7aedfcf 
Bumps [lru-cache](https://github.com/isaacs/node-lru-cache) from 7.15.0 to 7.16.0.
- [Release notes](https://github.com/isaacs/node-lru-cache/releases)
- [Changelog](https://github.com/isaacs/node-lru-cache/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-lru-cache@v7.15.0...v7.16.0)

---
updated-dependencies:
- dependency-name: lru-cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@marlonfsolis
fix(Pool): create PoolConnectionBase.d.ts interface to fix a typescri…
917888b 
…pt error.
@marlonfsolis
fix(Pool): add @typescript-eslint rules to avoid eslint errors.
bcfd307 
Moving the declaration up before use it.
@marlonfsolis
fix(Pool): remove 'use strict'; to avoid error ESLint: 'use strict' i…
ad97219 
…s unnecessary inside of modules.
@marlonfsolis
fix: remove 'use strict'; to avoid error ESLint: 'use strict' is unne…
576cc8b 
…cessary inside of modules.(strict)
@marlonfsolis
test(Pool): typing test for PoolConnection interface
f52a4a0
@dependabot @marlonfsolis
build(deps): bump lru-cache from 7.16.0 to 7.16.1
5e40872 
Bumps [lru-cache](https://github.com/isaacs/node-lru-cache) from 7.16.0 to 7.16.1.
- [Release notes](https://github.com/isaacs/node-lru-cache/releases)
- [Changelog](https://github.com/isaacs/node-lru-cache/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-lru-cache@v7.16.0...v7.16.1)

---
updated-dependencies:
- dependency-name: lru-cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @marlonfsolis
build(deps-dev): bump @types/node from 18.13.0 to 18.14.0
0bd22c1 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.13.0 to 18.14.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @marlonfsolis
build(deps-dev): bump @typescript-eslint/eslint-plugin
30d4bff 
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.52.0 to 5.53.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.53.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @marlonfsolis
build(deps-dev): bump @typescript-eslint/parser from 5.52.0 to 5.53.0
63c9d9c 
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.52.0 to 5.53.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.53.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @marlonfsolis
build(deps): bump lru-cache from 7.16.1 to 7.17.0
93be327 
Bumps [lru-cache](https://github.com/isaacs/node-lru-cache) from 7.16.1 to 7.17.0.
- [Release notes](https://github.com/isaacs/node-lru-cache/releases)
- [Changelog](https://github.com/isaacs/node-lru-cache/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-lru-cache@v7.16.1...v7.17.0)

---
updated-dependencies:
- dependency-name: lru-cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @marlonfsolis
build(deps-dev): bump @types/node from 18.14.0 to 18.14.1
e2b59d9 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.14.0 to 18.14.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@Daemonxiao @marlonfsolis
Add default connection attributes (#1825)
c49a6c4 
feat: add default connection attributes
@marlonfsolis
Merge remote-tracking branch 'origin/fix_typescript_poolconnection' i…
8913af0 
…nto fix_typescript_poolconnection
@marlonfsolis
Copy link
Author

@sidorares Andrey I add a small test in existing pool.ts tests. Hope this is fine.
I rebase and reword fallowing Github doc. Hope this is okay.
Let me know if need anything else.

@sidorares
Copy link
Owner

I'm not sure why previous commits are so different now. Can you rebase your changes to be on top of the current master? I think when you do this the "commits" tab should only show your commits

@rostalevicek
Copy link

Is there any progress? Can it be merged?

@marlonfsolis
Some changes
855744b 
Not sure what it was.
@marlonfsolis
Copy link
Author

It seems to be fixed already in a better and more elegant way.

@marlonfsolis marlonfsolis deleted the fix_typescript_poolconnection branch April 9, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marlonfsolis @sidorares @rostalevicek @Daemonxiao