Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Do not animate spoilers if system animations are disabled. #13016

Closed
wants to merge 1 commit into from

Conversation

Sgn-32
Copy link
Contributor

@Sgn-32 Sgn-32 commented Jun 21, 2023

Contributor checklist

  • Virtual Pixel XL, Android 12
  • My contribution is fully baked and ready to be merged as is

Description

The commit 272860f in 6.24.1 disables the animation of spoilers if system animations are disabled.
When system animations are disabled the draw function


is executed anyway, although the values of the particles do not change, due to dt = 0.

This PR changes this. The update function is called onetime (in the init with update(true)) to compute a spoiler particles image.
Every other call of update() is directly returned, if system animations are disabled.

@Sgn-32
Copy link
Contributor Author

Sgn-32 commented Jun 22, 2023

Screenshot of first PR. I will post a second PR soon.
The spoiler animation is stopped now by stopping the time animator, if system animation is disabled.

grafik

@Sgn-32 Sgn-32 force-pushed the Fix_Do_not_animate_spoilers branch from 38864f2 to 3de32c9 Compare June 22, 2023 14:55
@Sgn-32
Copy link
Contributor Author

Sgn-32 commented Jun 25, 2023

Checks failed:
This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.

@Sgn-32 Sgn-32 force-pushed the Fix_Do_not_animate_spoilers branch from 3de32c9 to 6391120 Compare June 27, 2023 16:29
@Sgn-32 Sgn-32 deleted the Fix_Do_not_animate_spoilers branch July 1, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant