Fix Do not animate spoilers if system animations are disabled. #13016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Description
The commit 272860f in 6.24.1 disables the animation of spoilers if system animations are disabled.
When system animations are disabled the draw function
Signal-Android/app/src/main/java/org/thoughtcrime/securesms/components/spoiler/SpoilerPaint.kt
Line 107 in 272860f
is executed anyway, although the values of the particles do not change, due to dt = 0.
This PR changes this. The update function is called onetime (in the init with update(true)) to compute a spoiler particles image.
Every other call of update() is directly returned, if system animations are disabled.