Allow building RUM with preconfigured SDK. #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you need to run spotless |
mateuszrzeszutek
approved these changes
Jul 4, 2023
...-instrumentation/src/main/java/io/opentelemetry/rum/internal/SdkPreconfiguredRumBuilder.java
Outdated
Show resolved
Hide resolved
...ry-android-instrumentation/src/main/java/io/opentelemetry/rum/internal/OpenTelemetryRum.java
Outdated
Show resolved
Hide resolved
...ry-android-instrumentation/src/main/java/io/opentelemetry/rum/internal/OpenTelemetryRum.java
Outdated
Show resolved
Hide resolved
…emetry/rum/internal/OpenTelemetryRum.java Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #1400 there was this conversation about "bring your own" sdk. While this has not been historically important with one vendor (Splunk), this will need to be relaxed when going into upstream.
So this provides a peer of
OpenTelemetryRumBuildercalledSdkPreconfiguredRumBuilder. This class does not provide a means to customize any of the various*ProviderCustomizerand assumes the user has already done all the hard work. For a single-vendor solution this is a bit of a foot gun, but we expect that opinionated distros can help fill in the important parts for their users.