Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Web3 signer validator definitions reloading on any request #3801

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Web3 signer validator definitions reloading on any request #3801

wants to merge 2 commits into from

Conversation

realbigsean
Copy link
Member

Issue Addressed

#3795

@realbigsean realbigsean mentioned this pull request Dec 14, 2022
Closed
@michaelsproul michaelsproul added val-client Relates to the validator client binary ready-for-review The code is ready for review v3.4.0 Minor release following v3.3.0 labels Dec 19, 2022
paulhauner
paulhauner approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice simple fix!

@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 9, 2023
@realbigsean
Web3 signer validator definitions reloading on any request (#3801)
1dd742d 
## Issue Addressed

#3795


Co-authored-by: realbigsean <sean@sigmaprime.io>
@bors
Copy link

bors bot commented Jan 9, 2023

This PR was included in a batch that was canceled, it will be automatically retried

@paulhauner
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Jan 9, 2023

Canceled.

@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 9, 2023
@realbigsean
Web3 signer validator definitions reloading on any request (#3801)
c85cd87 
## Issue Addressed

#3795


Co-authored-by: realbigsean <sean@sigmaprime.io>
@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 9, 2023
@paulhauner paulhauner mentioned this pull request Jan 9, 2023
Closed
3 tasks
@bors
Copy link

bors bot commented Jan 9, 2023

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Web3 signer validator definitions reloading on any request [Merged by Bors] - Web3 signer validator definitions reloading on any request Jan 9, 2023
@bors bors bot closed this Jan 9, 2023
bors bot pushed a commit that referenced this pull request Jan 11, 2023
@paulhauner
Release v3.4.0 (#3862)
ad85f56 
## Issue Addressed

NA

## Proposed Changes

Bump versions

## Additional Info

- [x] ~~Blocked on #3728, #3801~~
- [x] ~~Blocked on #3866~~
- [x] Requires additional testing
bors bot pushed a commit that referenced this pull request Jan 11, 2023
@paulhauner
Release v3.4.0 (#3862)
ad1aea4 
## Issue Addressed

NA

## Proposed Changes

Bump versions

## Additional Info

- [x] ~~Blocked on #3728, #3801~~
- [x] ~~Blocked on #3866~~
- [x] Requires additional testing
bors bot pushed a commit that referenced this pull request Jan 11, 2023
@paulhauner
Release v3.4.0 (#3862)
46a67c3 
## Issue Addressed

NA

## Proposed Changes

Bump versions

## Additional Info

- [x] ~~Blocked on #3728, #3801~~
- [x] ~~Blocked on #3866~~
- [x] Requires additional testing
bors bot pushed a commit that referenced this pull request Jan 11, 2023
@paulhauner
Release v3.4.0 (#3862)
38514c0 
## Issue Addressed

NA

## Proposed Changes

Bump versions

## Additional Info

- [x] ~~Blocked on #3728, #3801~~
- [x] ~~Blocked on #3866~~
- [x] Requires additional testing
@realbigsean realbigsean deleted the validator-reloading-fix branch November 21, 2023 16:18
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@realbigsean @Woodpile37
Web3 signer validator definitions reloading on any request (sigp#3801)
f6ae59e 
## Issue Addressed

sigp#3795


Co-authored-by: realbigsean <sean@sigmaprime.io>
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@paulhauner @Woodpile37
Release v3.4.0 (sigp#3862)
d52f244 
## Issue Addressed

NA

## Proposed Changes

Bump versions

## Additional Info

- [x] ~~Blocked on sigp#3728, sigp#3801~~
- [x] ~~Blocked on sigp#3866~~
- [x] Requires additional testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhauner paulhauner paulhauner approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge. v3.4.0 Minor release following v3.3.0 val-client Relates to the validator client binary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realbigsean @paulhauner @michaelsproul