Improve network parameters #5177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgeManning
added
ready-for-merge
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
5 tasks
|
@Mergifyio requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 4db84de |
This was referenced Feb 8, 2024
Merged
danielramirezch
pushed a commit
to danielramirezch/lighthouse
that referenced
this pull request
Feb 14, 2024
* Modify network parameters for current mainnet conditions
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current state of mainnet is changing due to how clients are subscribing to long lived subnets. The modification has lead to more scarcity in the subnets as we expected.
We are now seeing issues where clients are unable to find and maintain useful peers to span all subnets, leading to missed attestations and the warning log, failed to publish message with the error
InsufficientPeers. It is not enough for individual nodes to simply increase their peer counts, because it is often the case that other nodes on the network have already reached their peer limits and non-lighthouse clients often simply reject the connection. The best solution currently (and has been planned for a while) is to increase lighthouse's defaulttarget-peercount to ~120. However, we want to do this gradually. This PR takes an intermediate approach and sets the default value to 100.We have been testing a default value of 100 peers for a while now and load seems acceptable for small home users. See attached:
There is a secondary issue where Lighthouse attempts to maintain 6 peers for every required subnet. For nodes with lots of validators this becomes an impossible task with an 80 peer target and results in continuous discovery queries.
With a target peer count of 100, and each peers subscribing to two subnets, a healthy target peer count per subnet is 3. This should result in little to no discovery queries once the right set of peers are found. Having all nodes on the network update to this logic, should allow for more connections between all peers and more stability on the subnets.