Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validator liveness endpoint should accept string encoded indices #5184

Merged

Conversation

eserilev
Copy link
Collaborator

@eserilev eserilev commented Feb 5, 2024

Issue Addressed

#5182

Proposed Changes

use the ValidatorIndexData type within the warp filter to allow for deserializing string encoded indices as u64

Additional Info

@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. backwards-incompat Backwards-incompatible API change labels Feb 5, 2024
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Feb 8, 2024
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks!

@michaelsproul
Copy link
Member

@Mergifyio queue

Copy link

mergify bot commented Feb 9, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at e7ef2a3

mergify bot added a commit that referenced this pull request Feb 9, 2024
@mergify mergify bot merged commit e7ef2a3 into sigp:unstable Feb 9, 2024
28 of 29 checks passed
danielramirezch pushed a commit to danielramirezch/lighthouse that referenced this pull request Feb 14, 2024
…p#5184)

* deserialize string indices as u64

* client should send quoted indices
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompat Backwards-incompatible API change ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants