Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Deneb fork epoch for Gnosis #5242

Merged
merged 7 commits into from
Feb 19, 2024
Merged

Add Deneb fork epoch for Gnosis #5242

merged 7 commits into from
Feb 19, 2024

Conversation

paulhauner
Copy link
Member

Issue Addressed

Closes #5229

Proposed Changes

Adds the Deneb fork epoch as per gnosischain/specs#36.

Additional Info

NA

@paulhauner paulhauner added ready-for-review The code is ready for review v5.0.0 Q1 2024 labels Feb 15, 2024
@paulhauner paulhauner changed the base branch from stable to unstable February 15, 2024 08:08
@paulhauner paulhauner added work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels Feb 15, 2024
@realbigsean
Copy link
Member

I think CI's failing because the default here is 4096 but it should be 16384 https://github.com/sigp/lighthouse/blob/stable/consensus/types/src/chain_spec.rs#L957C1-L957C84

@paulhauner paulhauner added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Feb 17, 2024
paulhauner added a commit that referenced this pull request Feb 18, 2024
@paulhauner
Add Deneb fork epoch for Gnosis (#5242)
624c66c 
Squashed commit of the following:

commit 1422de9
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Feb 16 20:44:04 2024 +1100

    Fix chain spec values again

commit d61d53b
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Feb 16 20:25:43 2024 +1100

    Fix chain spec `max_per_epoch_activation_churn_limit`

commit 32b349e
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Feb 16 20:08:24 2024 +1100

    Change `MAX_PER_EPOCH_ACTIVATION_CHURN_LIMIT`

commit 8548506
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Feb 16 20:01:37 2024 +1100

    Adjust `min_epochs_for_block_requests`

commit 3305c10
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Feb 16 19:59:43 2024 +1100

    Update common/eth2_network_config/built_in_network_configs/gnosis/config.yaml

    Co-authored-by: realbigsean <seananderson33@GMAIL.com>

commit ca10127
Author: Paul Hauner <paul@paulhauner.com>
Date:   Thu Feb 15 19:09:50 2024 +1100

    Add deneb constants

commit 94285cf
Author: Paul Hauner <paul@paulhauner.com>
Date:   Thu Feb 15 19:06:32 2024 +1100

    Add Deneb fork epoch for Gnosis
@paulhauner paulhauner mentioned this pull request Feb 18, 2024
Merged
paulhauner added a commit that referenced this pull request Feb 18, 2024
@paulhauner
Add Deneb fork epoch for Gnosis (#5242)
7a6bd5b 
Squashed commit of the following:

commit 1422de9
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Feb 16 20:44:04 2024 +1100

    Fix chain spec values again

commit d61d53b
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Feb 16 20:25:43 2024 +1100

    Fix chain spec `max_per_epoch_activation_churn_limit`

commit 32b349e
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Feb 16 20:08:24 2024 +1100

    Change `MAX_PER_EPOCH_ACTIVATION_CHURN_LIMIT`

commit 8548506
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Feb 16 20:01:37 2024 +1100

    Adjust `min_epochs_for_block_requests`

commit 3305c10
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Feb 16 19:59:43 2024 +1100

    Update common/eth2_network_config/built_in_network_configs/gnosis/config.yaml

    Co-authored-by: realbigsean <seananderson33@GMAIL.com>

commit ca10127
Author: Paul Hauner <paul@paulhauner.com>
Date:   Thu Feb 15 19:09:50 2024 +1100

    Add deneb constants

commit 94285cf
Author: Paul Hauner <paul@paulhauner.com>
Date:   Thu Feb 15 19:06:32 2024 +1100

    Add Deneb fork epoch for Gnosis
@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 18, 2024
paulhauner added a commit that referenced this pull request Feb 18, 2024
@paulhauner
Add Deneb fork epoch for Gnosis (#5242)
f35fe16 
Squashed commit of the following:

commit 1422de9
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Feb 16 20:44:04 2024 +1100

    Fix chain spec values again

commit d61d53b
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Feb 16 20:25:43 2024 +1100

    Fix chain spec `max_per_epoch_activation_churn_limit`

commit 32b349e
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Feb 16 20:08:24 2024 +1100

    Change `MAX_PER_EPOCH_ACTIVATION_CHURN_LIMIT`

commit 8548506
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Feb 16 20:01:37 2024 +1100

    Adjust `min_epochs_for_block_requests`

commit 3305c10
Author: Paul Hauner <paul@paulhauner.com>
Date:   Fri Feb 16 19:59:43 2024 +1100

    Update common/eth2_network_config/built_in_network_configs/gnosis/config.yaml

    Co-authored-by: realbigsean <seananderson33@GMAIL.com>

commit ca10127
Author: Paul Hauner <paul@paulhauner.com>
Date:   Thu Feb 15 19:09:50 2024 +1100

    Add deneb constants

commit 94285cf
Author: Paul Hauner <paul@paulhauner.com>
Date:   Thu Feb 15 19:06:32 2024 +1100

    Add Deneb fork epoch for Gnosis
@paulhauner
Copy link
Member Author

@Mergifyio queue

@mergify Mergify
Copy link

mergify bot commented Feb 19, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at e22c9ee

mergify bot added a commit that referenced this pull request Feb 19, 2024
@mergify
Merge of #5242
23db62a
This was referenced Feb 19, 2024
Closed
Merged
Merged
@mergify mergify bot merged commit e22c9ee into sigp:unstable Feb 19, 2024
29 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realbigsean realbigsean realbigsean left review comments

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge. v5.0.0 Q1 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schedule Gnosis dencun hardfork
3 participants
@paulhauner @realbigsean @dapplion