Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete ancient, unused HTTP docs #5281

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

michaelsproul
Copy link
Member

Proposed Changes

Delete an old http.md file from the book which isn't referenced from anywhere.

@michaelsproul michaelsproul added code-quality docs Documentation ready-for-review The code is ready for review v5.1.0 Q2 2024 labels Feb 23, 2024
@chong-he
Copy link
Member

LGTM.

The content of the file is already covered in: https://lighthouse-book.sigmaprime.io/api-bn.html so it is good to remove this file

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 25, 2024
@michaelsproul
Copy link
Member Author

@Mergifyio queue

Copy link

mergify bot commented Feb 25, 2024

queue

🛑 The pull request has been removed from the queue default

Pull request #5281 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul
Copy link
Member Author

@Mergifyio dequeue

Copy link

mergify bot commented Feb 26, 2024

dequeue

✅ The pull request has been removed from the queue default

@michaelsproul
Copy link
Member Author

@Mergifyio requeue

Copy link

mergify bot commented Feb 26, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Feb 26, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at de6ede1

@mergify mergify bot merged commit de6ede1 into sigp:unstable Feb 26, 2024
30 checks passed
mergify bot added a commit that referenced this pull request Feb 26, 2024
@michaelsproul michaelsproul deleted the delete-old-http-md branch February 26, 2024 05:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality docs Documentation ready-for-merge This PR is ready to merge. v5.1.0 Q2 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants