Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macOS build by updating cc #5393

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix macOS build by updating cc #5393

merged 1 commit into from
Mar 12, 2024

Conversation

michaelsproul
Copy link
Member

Issue Addressed

Fix compilation on newer versions of macOS (14.3-14.4 tested) by bumping the cc version.

Without this change leveldb fails to compile with an error like:


  make[3]: *** read jobs pipe: Resource temporarily unavailable.  Stop.
  make[3]: *** Waiting for unfinished jobs....
  make[2]: *** [CMakeFiles/snappy.dir/all] Error 2
  make[1]: *** [all] Error 2
  thread 'main' panicked at /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.50/src/lib.rs:1098:5:

  command did not execute successfully, got: exit status: 2

  build script failed, must exit now
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@michaelsproul michaelsproul added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! infra-ci v5.2.0 Q2 2024 labels Mar 12, 2024
@michaelsproul michaelsproul mentioned this pull request Mar 12, 2024
Merged
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Mar 12, 2024
@jimmygchen
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Mar 12, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 1d7223f

mergify bot added a commit that referenced this pull request Mar 12, 2024
@mergify
Merge of #5393
32db86b
@mergify mergify bot mentioned this pull request Mar 12, 2024
Closed
5 tasks
@mergify mergify bot merged commit 1d7223f into sigp:unstable Mar 12, 2024
29 checks passed
@michaelsproul michaelsproul deleted the update-cc branch March 12, 2024 02:59
danielramirezch pushed a commit to danielramirezch/lighthouse that referenced this pull request Mar 12, 2024
@michaelsproul @danielramirezch
Fix macOS build by updating cc (sigp#5393)
b9bd31a 
* Fix macOS build by bumping `cc`
dapplion pushed a commit to dapplion/lighthouse that referenced this pull request Mar 13, 2024
@michaelsproul @dapplion
Fix macOS build by updating cc (sigp#5393)
8edf45c 
* Fix macOS build by bumping `cc`
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
infra-ci low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. v5.2.0 Q2 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelsproul @jimmygchen @dapplion