Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds with slasher-redb #6077

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Conversation

michaelsproul
Copy link
Member

Issue Addressed

Currently unstable fails to build with the slasher-redb feature due to a last-minute tweak I made to the redb impl prior to merging.

Proposed Changes

  • Correct the compilation error
  • Run the tests for the redb slasher on CI (would have caught this issue)

@michaelsproul michaelsproul added bug Something isn't working ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! v5.3.0 Q3 2024 release with database changes! labels Jul 11, 2024
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 11, 2024
@jimmygchen
Copy link
Member

Oops, there's one failing slasher test: failed_override_with_existing_mdbx_db

@michaelsproul
Copy link
Member Author

Deleted the failing test. It's a duplicate of another test with the same name failed_override_with_existing_mdbx_db which tests the case where you already have an MDBX database and start without MDBX enabled

@michaelsproul
Copy link
Member Author

Ok third time lucky. Disabled all those slasher override tests when redb is involved.

@michaelsproul
Copy link
Member Author

@mergify queue

Copy link

mergify bot commented Jul 12, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Jul 12, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Jul 12, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 7697c12

mergify bot added a commit that referenced this pull request Jul 12, 2024
@mergify mergify bot merged commit 7697c12 into sigp:unstable Jul 12, 2024
28 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge. v5.3.0 Q3 2024 release with database changes!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants