Add requires suggested-fee-recipient flag when always-prepare-payload is set

[chong-he]

Currently, when the flag --always-prepare-payload is set and a fee recipient is not set in the beacon node, the beacon node will print the log:

CRIT Fee recipient unknown proposer_index: 368409, msg: the suggested_fee_recipient was unknown during block production. a junk address was used, rewards were lost! check the --suggested-fee-recipient flag and VC configuration., service: exec

which can be noisy and not desirable. This PR changes it so that the flag --suggested-fee-recipient must always be set when --always-prepare-payload is set. The documentation is also updated to reflect this change.

Thanks to the discussion raised by @just_in_time and @michaelsproul in Discord

[michaelsproul]

Based on the test failure it seems like suggested-fee-recipient requires execution-endpoint, so you need to set that flag as well

[chong-he]

Based on the test failure it seems like suggested-fee-recipient requires execution-endpoint, so you need to set that flag as well

Thank you!
Added in 5ed5de4 and 1375779 and looks good now

[realbigsean]

@mergify queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[michaelsproul]

@mergify requeue

[mergify]

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 3859c9b