Fix proposer-nodes cli flag name

[jimmygchen]

Issue Addressed

Getting this error while trying to run validator client locally (with a custom built docker image) and it shuts down immediately with:

Unable to initialize validator config: Unable to parse proposer_nodes: Unknown argument or group id.  Make sure you are using the argument id and not the short or long flags

This PR fixes the --proposer-node flag parsing to use the correct arg name.

lighthouse/validator_client/src/cli.rs

Lines 33 to 35 in 947e2e8

	Arg::new("proposer-nodes")
	.long("proposer-nodes")
	.value_name("NETWORK_ADDRESSES")

[jimmygchen]

Note this was tested on a custom built image. I can't reproduce the crash using an image built using our Dockerfile, so it could be that the image wasn't built with --locked, and potentially using a different clap version.

[michaelsproul]

I can't reproduce the crash, even building without the lockfile (cargo install --path lighthouse). Were you using the --proposer-nodes flag?

Regardless, I think we should fix it

[jimmygchen]

Nope I wasn’t using the flag. Hmm really weird!

[michaelsproul]

When did you build the image? I notice there were two clap versions released really close together: https://crates.io/crates/clap/versions

[michaelsproul]

Can we add a test in lighthouse/tests/validator_client.rs so this doesn't regress?

[jimmygchen]

I used this image: kevaundray/lighthouse-eth:das-dbg-04d9eef8a

built by kev for this issue:
#6105 (comment)

I’ve reach out to him and asked whether this was produced with our local testnet scripts.

[jimmygchen]

Good idea, I’ll add a test!

[michaelsproul]

Nice

[michaelsproul]

@mergify queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 549035d