Delete --builder-profit-threshold flag

[chong-he]

There is a bug when using the deprecated flag --builder-profit-threshold in Lighthouse 5.2.0 and above, reported by @CouzDelCouzzz on Discord: https://discord.com/channels/605577013327167508/605577013331361793/1262698540358963261

To reproduce, run Lighthouse with the flag, e.g.:

./lighthouse bn --checkpoint-sync-url https://mainnet.checkpoint.sigp.io --builder-profit-threshold 100 --execution-endpoint http://localhost:8551 --execution-jwt /home/hi/.ethereum/geth/jwtsecret

@michaelsproul mentioned that this is due to the parse_flag should only be used when the flag does not take an argument (i.e., the flag is a boolean, such as the --metrics flag):

lighthouse/beacon_node/src/config.rs

Lines 1379 to 1381 in 9e12c21

	if parse_flag(cli_args, "disable-enr-auto-update") {
	config.discv5_config.enr_update = false;
	}

This is not the case for --builder-profit-threshold which takes an argument:

lighthouse/beacon_node/src/config.rs

Lines 338 to 344 in 9e12c21

	if parse_flag(cli_args, "builder-profit-threshold") {
	warn!(
	log,
	"Ignoring --builder-profit-threshold";
	"info" => "this flag is deprecated and will be removed"
	);
	}

This PR deletes the --builder-profit-threshold flag so that the panic is not possible to manifest.

[michaelsproul]

Nice. Let's do it

[michaelsproul]

@mergify queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 647992b