-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator manager commands for the Keymanager APIs #6261
base: unstable
Are you sure you want to change the base?
Conversation
…anager-standard-keystore
If it's not too much of a hassle it'd be cool to define the new cli flags here w/ clap derive. Alternatively, I can make a separate PR to migrate to derive once this is merged EDIT: I think we can just migrate to clap derive later after this PR is merged. thanks for taking a look CK! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very clean!
I do have a few suggestions for you which range from easy fixes to large rewrites 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a decent amount of code duplication between this and the import_validators.rs
file.
It would be nice if would could merge the two into the same command, with maybe a --use-standard-format
flag or something in order to specify which format we are using (next level would be detecting which format it is automagically. I believe we can also make certain flags mutually exclusive so we can disable the ones that are not applicable for each format.
This may not be worth the complexity, but it's just quite unintuitive (imo) to have an import
subcommand and then also an import-standard
subcommand.
Co-authored-by: Mac L <mjladson@pm.me>
Issue Addressed
Proposed Changes
Add commonds to
lighthouse vm
to support the Keymanager API to manage local keystores, i.e.,list
,import
anddelete
Additional Info
Building on top of @pahor167 PR: #5347