-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate validator client to clap derive #6300
base: unstable
Are you sure you want to change the base?
Conversation
if validator_client_config.web3_signer_keep_alive_timeout == 0 { | ||
config.web3_signer_keep_alive_timeout = None | ||
} else { | ||
config.web3_signer_keep_alive_timeout = Some(Duration::from_millis( | ||
validator_client_config.web3_signer_keep_alive_timeout, | ||
)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note the breaking change here. Since I've defined web3_signer_keep_alive_timeout
as a u64
, null
is no longer a valid option. Users will need to use 0
instead.
If this breaking change is too intrusive I can define web3_signer_keep_alive_timeout
as a string and we can keep functionality as is.
Issue Addressed
Partially #5900
Proposed Changes
Migrate the validator client cli to clap derive