Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for ActiveSamplingRequest #6307

Open
wants to merge 6 commits into
base: unstable
Choose a base branch
from

Conversation

ackintosh
Copy link
Member

Issue Addressed

I've implemented batching sampling requests in #6256, but there are no unit tests for it yet.

Proposed Changes

Add a test for ActiveSamplingRequest to ensure that the requests are batched, and check the status of the requests.

@ackintosh ackintosh added ready-for-review The code is ready for review das Data Availability Sampling labels Aug 26, 2024
@mergify mergify bot deleted the branch sigp:unstable August 27, 2024 04:10
@mergify mergify bot closed this Aug 27, 2024
@michaelsproul michaelsproul reopened this Aug 27, 2024
@michaelsproul
Copy link
Member

Please update to point at unstable by either:

  1. Rebasing on unstable (if your branch has a small number of commits that are easy to tease out), or
  2. Merging origin/das into this PR: git fetch origin; git merge origin/das. This will result in the smallest number of conflict resolutions and is better for branches that already contain merge commits or have extensive history.

@ackintosh ackintosh force-pushed the add-test-for-active-sampling-request branch from 556b0a9 to e0b6b2b Compare August 27, 2024 22:24
@ackintosh ackintosh changed the base branch from das to unstable August 27, 2024 22:25
@ackintosh
Copy link
Member Author

Thanks for the comment Michael! I've rebased this on unstable.

}

#[test]
fn test_active_sampling_request() {
Copy link
Collaborator

@dapplion dapplion Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write tests in this format and file?

fn custody_lookup_happy_path() {

We recently avoided adding unit tests too close to impl for event-based tests

@ackintosh
Copy link
Member Author

Thanks @dapplion! I've written tests in the tests.rs file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
das Data Availability Sampling ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants