-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for ActiveSamplingRequest #6307
base: unstable
Are you sure you want to change the base?
Add test for ActiveSamplingRequest #6307
Conversation
Please update to point at
|
556b0a9
to
e0b6b2b
Compare
Thanks for the comment Michael! I've rebased this on |
} | ||
|
||
#[test] | ||
fn test_active_sampling_request() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you write tests in this format and file?
fn custody_lookup_happy_path() { |
We recently avoided adding unit tests too close to impl for event-based tests
Thanks @dapplion! I've written tests in the tests.rs file. |
Issue Addressed
I've implemented batching sampling requests in #6256, but there are no unit tests for it yet.
Proposed Changes
Add a test for ActiveSamplingRequest to ensure that the requests are batched, and check the status of the requests.