Make max_blobs_per_block a config parameter #6329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanjay176
force-pushed
the
max-blobs-preset
branch
from
8b665b5
to
52bb581
Compare
jimmygchen
reviewed
Sep 5, 2024
| let (block, blobs_vec) = | ||
| generate_rand_block_and_blobs::<E>(ForkName::Deneb, NumBlobs::Random, &mut rng); | ||
| let mut blobs: FixedVector<_, <E as EthSpec>::MaxBlobsPerBlock> = FixedVector::default(); | ||
| let max_len = spec.max_blobs_per_block(block.epoch()) as usize; |
There was a problem hiding this comment.
The epoch here will be random right?
jimmygchen
reviewed
Sep 5, 2024
| @@ -214,6 +262,85 @@ where | |||
| } | |||
| } | |||
|
|
|||
| /// Emulates a SSZ `Vector`. | |||
| #[derive(Clone, Debug)] | |||
| pub struct RuntimeFixedList<T> { | |||
There was a problem hiding this comment.
oh we should probably move this to a separate file
jimmygchen
reviewed
Sep 5, 2024
| @@ -676,7 +676,8 @@ impl<E: EthSpec> ExecutionBlockGenerator<E> { | |||
| ForkName::Deneb | ForkName::Electra => { | |||
| // get random number between 0 and Max Blobs | |||
| let mut rng = self.rng.lock(); | |||
| let num_blobs = rng.gen::<usize>() % (E::max_blobs_per_block() + 1); | |||
| // TODO(pawan): thread the chainspec value here somehow | |||
| let num_blobs = rng.gen::<usize>() % 6; | |||
There was a problem hiding this comment.
Suggested change
| let num_blobs = rng.gen::<usize>() % 6; | |
| let num_blobs = rng.gen::<usize>() % (6 + 1); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
Change
max_blobs_per_blockfrom a preset value to a config value. This affects a lot of the codebase where we have to use runtime variants of ssz List and Vector.