Fix electra light client types #6361
Open
+497
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsist-light-client-updates
…rsist-light-client-updates
…rsist-light-client-updates
eserilev
added
ready-for-review
…serilev/lighthouse into light-client-electra
…serilev/lighthouse into light-client-electra
dapplion
reviewed
Sep 10, 2024
…ght-client-electra
dapplion
reviewed
Sep 17, 2024
consensus/types/src/beacon_state.rs
Outdated
| generalized_index: usize, | ||
| ) -> Result<Vec<Hash256>, Error> { | ||
| // 1. Convert generalized index to field index. | ||
| let field_index = match generalized_index { |
There was a problem hiding this comment.
Just match on the self.fork_unchecked() and pick the right gindex. No need to pass the generalized_index as argument. I guess now that the function is repeated we don't need to list the 1,2,3,4 steps on each function. Same for compute_sync_committee_proof if you split the function into compute_next_sync_committee_proof and compute_current_sync_committee_proof they are short functions that are no longer fallible. It simplifies the logic on the caller side too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Resolves #6002
Resolves #4022
Proposed Changes
Update light client types to be compatible with electra
Related spec PR:
ethereum/consensus-specs#3811
Blocked by #5915