Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry command line flag on rekor-cli #1097

Merged
merged 5 commits into from
Oct 6, 2022

Conversation

bobcallaway
Copy link
Member

Depends-on: #1096

Release Note

adds --retry option to rekor-cli commands to automatically retry calls to a rekor server based on transient errors; default value is to retry 3 times

Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner October 5, 2022 17:36
cpanato
cpanato previously approved these changes Oct 5, 2022
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coool

Signed-off-by: Bob Callaway <bcallaway@google.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Merging #1097 (16dc702) into main (a47adc1) will increase coverage by 0.04%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##             main    #1097      +/-   ##
==========================================
+ Coverage   63.73%   63.78%   +0.04%     
==========================================
  Files          82       82              
  Lines        7567     7585      +18     
==========================================
+ Hits         4823     4838      +15     
- Misses       2119     2121       +2     
- Partials      625      626       +1     
Flag Coverage Δ
e2etests 48.56% <70.83%> (+0.13%) ⬆️
unittests 40.91% <75.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/rekor-cli/app/log_proof.go 10.93% <0.00%> (ø)
cmd/rekor-cli/app/get.go 50.68% <100.00%> (ø)
cmd/rekor-cli/app/log_info.go 55.00% <100.00%> (ø)
cmd/rekor-cli/app/pflags.go 88.48% <100.00%> (+1.12%) ⬆️
cmd/rekor-cli/app/root.go 66.66% <100.00%> (+0.59%) ⬆️
cmd/rekor-cli/app/search.go 57.85% <100.00%> (ø)
cmd/rekor-cli/app/upload.go 53.98% <100.00%> (ø)
cmd/rekor-cli/app/verify.go 56.19% <100.00%> (ø)
pkg/types/alpine/v0.0.1/entry.go 72.35% <0.00%> (-1.22%) ⬇️
pkg/types/helm/v0.0.1/entry.go 47.47% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bobcallaway bobcallaway merged commit 45f17ce into sigstore:main Oct 6, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants