Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing event: sign/root-v10 #171

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Signing event: sign/root-v10 #171

merged 6 commits into from
Sep 9, 2024

Conversation

sigstore-bot
Copy link
Member

Processing signing event sign/root-v10, please wait.

Signed-off-by: TUF-on-CI <41898282+github-actions[bot]@users.noreply.github.com>
@sigstore-bot
Copy link
Member Author

Current signing event state

Event sign/root-v10 (commit 6d3280f)

❌ root

Role root is unsigned and not yet verified
Still missing signatures from @joshuagl, @jku, @mnm678, @kommendorkapten
Signers can sign these changes by running tuf-on-ci-sign sign/root-v10

@jku
Copy link
Member

jku commented Aug 29, 2024

I think we've seen now that the version bump signing events work.

How about bumping the root expiry to 6 months instead of 3?

@kommendorkapten
Copy link
Member

How about bumping the root expiry to 6 months instead of 3?

Agreed.

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@sigstore-bot
Copy link
Member Author

Current signing event state

Event sign/root-v10 (commit b38702e)

❌ root

Role root is not yet verified. It is signed by 1/2 (1/2) signers (@jku).
Still missing signatures from @joshuagl, @mnm678, @kommendorkapten
Signers can sign these changes by running tuf-on-ci-sign sign/root-v10

@jku
Copy link
Member

jku commented Aug 31, 2024

Changed the root expiry period to 182 days. Feel free to sign when you have time (30 days until expiry so no rush).

@jku
Copy link
Member

jku commented Sep 6, 2024

I will include sigstore/root-signing#1339 here as well:

  • start signing timestamp every day

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@sigstore-bot
Copy link
Member Author

Current signing event state

Event sign/root-v10 (commit 163c6d5)

❌ root

Role root is not yet verified. It is signed by 1/2 (1/2) signers (@jku).
Still missing signatures from @kommendorkapten, @mnm678, @joshuagl
Signers can sign these changes by running tuf-on-ci-sign sign/root-v10

@jku
Copy link
Member

jku commented Sep 6, 2024

the tuf-on-ci-sign output isn't perfect: it does not notify signer that timestamp signing period changes: theupdateframework/tuf-on-ci#432

Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
@sigstore-bot
Copy link
Member Author

Current signing event state

Event sign/root-v10 (commit 058e358)

✅ root

Role root is verified and signed by 2/2 (2/2) signers (@jku, @kommendorkapten).
Still missing signatures from @mnm678, @joshuagl
Signers can sign these changes by running tuf-on-ci-sign sign/root-v10

Signing event is successful

Threshold of signatures has been reached: this signing event can be reviewed and merged.

@sigstore-bot sigstore-bot marked this pull request as ready for review September 9, 2024 06:33
@jku
Copy link
Member

jku commented Sep 9, 2024

Documenting all of the changes just in case it's not clear:

  • root goes from expiry period of 91 days to 182 days
  • timestamp goes from signing period of 4 days to 6 days -- effectively meaning online signing happens ~ every day

The first one brings root-signing-staging in line with production root-signing. The second one is basically a test before we decide if we want to do this same change in production root-signing

I'm planning to merge today.

@jku jku merged commit 7a9ab7d into main Sep 9, 2024
2 checks passed
@jku jku deleted the sign/root-v10 branch September 9, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants