-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: Enable tuf-on-ci #1313
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm filing an issue to remove some of the expected checks and will fix this PR so it does not remove the workflow linting |
jku
force-pushed
the
enable-tuf-on-ci
branch
2 times, most recently
from
August 12, 2024 11:48
4391892
to
3cea9e7
Compare
@kommendorkapten please have a look at some point |
kommendorkapten
previously approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note that deployment to GCS is still commented out in publish workflow. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Delete legacy (meaning non- tuf-on-ci) * timestamp and snapshot workflows * GCS uploading workflows * signing event management workflows (dealing with "ceremony/" dirs) * various verification workflows: now handled by the tuf-on-ci tests and custom-test.yml Remove these outright to prevent accidental changes to metadata from two different maintenance systems. If it turns out the migration will not be successful in the timeframe it has, the PR that contains this commit needs to be reverted so the legacy system can continue operation. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
rebased on main to keep this up-to-date. |
closing as I've merged to PR 1323 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge, this is informative only at this point.
These are the workflow changes I propose we include in the initial signing event PR, I'm making this a draft PR already so these can be reviewed separately and in advance of the actual signing event (#929).
Contents