Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Signing event: sign/migration" #1345

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Revert "Signing event: sign/migration" #1345

merged 1 commit into from
Aug 30, 2024

Conversation

kommendorkapten
Copy link
Member

Reverts #1323

@jku
Copy link
Member

jku commented Aug 30, 2024

Copying from keyholders slack:

We just tried merging 1323 and encountered an issue that is forcing us to revert the change

  • I seem to have made a mistake with the KMS key id
  • Fix unfortunately likely requires keyholders to re-sign, apologies for that

So yeah, revert seems like the right path: we'll try again early next week (we can re-use the same branch)

@kommendorkapten kommendorkapten merged commit 92787ea into main Aug 30, 2024
21 checks passed
@kommendorkapten kommendorkapten deleted the revert-1323-sign/migration branch August 30, 2024 16:47
@jku jku mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jku jku jku approved these changes

@haydentherapper haydentherapper Awaiting requested review from haydentherapper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kommendorkapten @jku