Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuf-on-ci migration: Enable publishing to production #1354

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

jku
Copy link
Member

@jku jku commented Sep 3, 2024

Switch on the publishing to production GCS bucket (which was left off in the tuf-on-ci migration for some manual testing)

  • The preprod tests (TUF smoke test, sigstore client tests) are green. This covers cosign, sigstore-go, sigstore-python, sigstore-java, sigstore-js
  • We have manually tested a few clients, including cosign v2.2.0
  • this will unfortunately break sigstore-rs temporarily (root-signing metadata is incompatible with current sigstore-rs #1251)
  • There is no rush but a bit of urgency: on-call starts getting alerts on Wednesday (because of timestamp that expires on 2024-09-06).

Fixes #1340

Asking for reviews from at least @haydentherapper and @kommendorkapten

Testing looks good, let's push the tuf-on-ci managed repository to
production GCS bucket.

Fixes sigstore#1340

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku
Copy link
Member Author

jku commented Sep 3, 2024

marking draft just to make sure we don't move fast and break things -- I believe this PR is ready and we can merge but let's make sure there is a consensus.

Also sigstore/sigstore-probers#270 should preferably be merged before this

@jku jku marked this pull request as draft September 3, 2024 10:02
@jku
Copy link
Member Author

jku commented Sep 3, 2024

One more detail: enabling tuf-on-ci will stop publishing non-versioned root, snapshot and targets:

  • this is planned deprecation: no-one should be using these files
  • load balancer logs show a number of requests for non-versioned metadata (20k per day) but our understanding is that these are old cosign versions in CI runs that have been consistently failing for a long time already:
    • cosign used to download these non-versioned files for "debug purposes" after the actual, versioned, metadata update had already failed: this seems to be at least an overwhelming majority of the non-versioned requests
    • these "debug request" use the same default "go-http-client" user agent as cosign normally does but they are identifiable because of the unusual order of requests

@jku jku marked this pull request as ready for review September 3, 2024 15:37
@jku jku merged commit a4b685e into sigstore:main Sep 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch tuf-on-ci "publish-to-production" on
3 participants