Workflow updates #1378
Merged
Workflow updates #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no go code anymore Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Test an older cosign version we want to support (we don't have the maintainer resources for a full matrix of all versions of all clients, but cosign is the most used client by far so let's test that) This has been tested in root-signing-staging. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
signing-event can result in strange PR comments getting generated if the workflow runs in signers fork. Prevent this. This has been tested in root-signing-staging. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
test.yml and test-gcs.yml currently always fail if the repository is not valid for 3 days (or if root & targets are not valid in 30 days). This is reasonable for standalone tests but not when tests are run during publish: As an example publishing should succeed after online signing even if root is expiring in a few weeks. Do not require repository to be valid at a future date when tests are running as reusable workflow (in other words from publish.yml), only require it to be valid at current time. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
haydentherapper
approved these changes
Sep 10, 2024
kommendorkapten
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains four separate workflow changes that I can put in separate PRs if requested to. These are all workflow related changes that have been tested in root-signing-staging:
Fixes #1376