Publish to a hosting directly #691
Milestone
Comments
|
Ok, yes, I think it would make sense from a user perspective to have an action "publish" that is straight forward! In our case, we use Nextcloud/webdav to integrate with silex. In term of ux, it would be just a bit of cosmetic to improve the user experience from "target folder" to "publish". To choose the website-name, we have something stupid for now, just a So if we think a bit more meta, Indie help people with webdav to publish their website.
Then we would have a slick "publish" experience! |
|
Interesting! I guess the website-name.txt is ok for now We would then do a "Indie Hosters" publish target, with the hard coded values
Is it possible to access to the user's webdav or FTP with oauth? This would allow the user to connect to indie hosters and not memorize the ftp/webdav login/pass, and also to avoid your users to give Silex the password |
|
Actually, you don't even need to purchase :) We have a free account, and you have 50MB, which should be enough to get started. Yes, oauth is in Nextcloud now. If you need help on the implementation, I can either help myself, or ask the relevant person on Nextcloud side :) |
|
Oh wow cool!! Did you hear that @JbIPS ? :D The credentials would be the same as Indie Hosters account? |
|
I could create the oauth2 creds for you |
|
👍 |
|
Note for the GitHub pages service: there is an API to monitor progress and get the final URL where the website is accessible |
|
Cédric alias arti de Gandi.net me conseille de regarder ca It's kind of game changing for how the users can connect their domain name |
|
That's awesome! It's like the Unifile of DNS! We definitely have to look at that |
|
Hi guys |
|
@lexoyo I checked quickly this "domain connect" but didn't see big support in the wild. |
|
Hello |
|
The idea is to have a route which serves a list of available hosting providers for the Silex instance |
|
My proof of concept seems to work, could you try and tell me what you think @pierreozoux @clemos @Godzone ? Here is a test you can do:
Please tell me if you understand how to publish to an FTP or any folder as it used to be the normal use case? |
|
As a POC this is looking good.
I had a play around using FTP and seemed to strike the same issue I had some time ago with the various folders not being created. The UI said it was creating testsite4/assets etc but the were not
Will the message surrounding the Website URL be configurable, I would not want to send a customer else where when we sell domains. In fact I would rather pre-fill the URL with the website they selected in our portal as the would already have a domain associated with it.
Glen.
|
|
Ok thx for testing!!! The FTP issue should be fixed, maybe @JbIPS you could check that you fix is live? Concerning the options and customizations, there are some already which you can check here (the providers will be dynamic at one point just like unifile services and you will provide yours only on the instance you host) As you can see the hosting providers have the ability to
A few questions for you Glen and others maybe
|
|
On 8/09/2018, at 8:25 AM, Alex Hoyau ***@***.***> wrote:
A few questions for you Glen and others maybe
Are the concepts of hosting providers and vhost clear and useful?
Did you understand the user experience?
Yes, they are but in our context, I am not sure they would be useful. When we setup a site it gets its own folder and corresponding user and is configured as a vHost on our Apache web servers. Whilst we have several people who have created websites in subfolders, they are accesses via a parent domains URL e.g. http://www.domain/webste1/ etc.
In order to see how we might use it, I’d have to set it up on our system and try some options. I do think the direction you have taken is good. As always it will be the detail that determines how useful it will be.
Glen.
|
ok, so this is also covered in my opinion but I would consider it an advanced option, one would have to select "use website settings", which would open the publish settings where the user can select a folder with cloud explorer. What do you think?
|
|
@Godzone I think I will replace "use website settings" by "Choose a folder", and then when the user presses "next" i will display a "browse" button which will open CE |
|
On 11/09/2018, at 9:35 PM, Alex Hoyau ***@***.***> wrote:
@Godzone <https://github.com/godzone> I think I will replace "use website settings" by "Choose a folder", and then when the user presses "next" i will display a "browse" button which will open CE
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#691 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIAqGEby5BIWSWULhBugg_EwdBKDVXsvks5uZ4PTgaJpZM4SJatK>.
How can I get what you have so far, I’d like to play around more in our environment
|
|
There are 2 different branches which concern your use case, I will soon merge them to continue on one of them Publish to a hosting directly:
Silex config
I have started a wiki page with content about these issues |
|
here is an example of a custom Silex integration |
|
Hi! |
|
It looks like this, there are several steps and options |
|
Hi |
|
@Godzone I took some time to make a complete example with code and documentation Here it is, in the same repo as before: https://github.com/lexoyo/silex-for-hosting-company Could you read the readme and tell me what you think? Feel free to fork it and propose changes First you will need implement a custom authentication strategy here Also I remember you have a notion of multiple accounts for each user, so I would suggest that you do this
We still need to figure out (cc @JbIPS )
|
|
Oh and could you open a new issue for your specif case please |
|
On 25/02/2019, at 12:48 PM, Alex Hoyau ***@***.***> wrote:
Oh and could you open a new issue for your specif case please
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#691 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIAqGMqfNwVAgHbsvoJQun3PCIk4--qMks5vQyTUgaJpZM4SJatK>.
I have got the service side sort of working but when I try to publish, I get this error. I haven’t modified your custom-provider.js code as I assumed it would at least do something albeit not what I want.
TypeError: hostingProvider.getVhosts is not a function
at router.get (/usr/local/silex-for-hosting-company/node_modules/silex/dist/server/PublishRouter.js:79:21)
at Layer.handle [as handle_request] (/usr/local/silex-for-hosting-company/node_modules/express/lib/router/layer.js:95:5)
at next (/usr/local/silex-for-hosting-company/node_modules/express/lib/router/route.js:137:13)
at Route.dispatch (/usr/local/silex-for-hosting-company/node_modules/express/lib/router/route.js:112:3)
at Layer.handle [as handle_request] (/usr/local/silex-for-hosting-company/node_modules/express/lib/router/layer.js:95:5)
I was intending to work on it from then.
It is not clear to me what the client is going to do. I am not using vHosts so that part needs to be a null op in my case.
Glen.
|
Closed
great! is it based on my my example? on fs service?
It is strange, it is defined here I just tried with your fork and it works, it does publish to /Website
you need to publish somewhere, where do you want to publish? |
|
On 7/03/2019, at 7:47 AM, Alex Hoyau ***@***.***> wrote:
I have got the service side sort of working
great! is it based on my my example? on fs service?
Yes, I haven’t changed it much. I used the same login as my previous implementation but then needed to change the parameters for the actions to
super.readdir(session, `${ session.rootPath }/${ path }`);
As the user’s dir is provided when they login.
This part works fine but when files are created they are being created by ‘root’, our website management functions in our portal has an option already to correct ownership and permissions which sets all files and directories correctly. The user will just need to use this function after creating files.
but when I try to publish, I get this error. I haven’t modified your custom-provider.js code as I assumed it would at least do something albeit not what I want.
It is strange, it is defined here <https://github.com/lexoyo/silex-for-hosting-company/blob/master/custom-provider.js#L57>
I just tried with your fork and it works, it does publish to /Website
I am not using vHosts so that part needs to be a null op in my case.
you need to publish somewhere, where do you want to publish?
I know it is strange I did not expect an error as I have not made any changes to the custom-provider code, so I am assuming my changes to the custom-service some how break things.
In my case, I want to publish back into the users home folder using fs service. Which should be straight forward but I am not sure where to start with modifying you example.
Glen.
|
|
Glen could you make it? |
|
On 9/03/2019, at 1:28 PM, Alex Hoyau ***@***.***> wrote:
Glen could you make it?
Can you try and see if the project works without your modifications?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#691 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIAqGDYgJjgbhN7noo0Mnvx_cNbRX2laks5vUwAWgaJpZM4SJatK>.
I created a second clone of the repo. And get this
-bash-4.2$ npm run build
***@***.*** build /usr/local/silex-for-hosting-company
npm run build:templates && npm run build:components
***@***.*** build:templates /usr/local/silex-for-hosting-company
cp -r templates/* `node_modules`/silex-templates/
***@***.*** build:components /usr/local/silex-for-hosting-company
cp components/* `node_modules`/silex/src/prodotype/components/ && cd `node_modules`/silex/ && npm run build:prodotype
***@***.*** build:prodotype /usr/local/silex-for-hosting-company/node_modules/silex
mkdir -p dist/client/libs/prodotype/components && prodotype src/prodotype/components dist/client/libs/prodotype/components/ && prodotype src/prodotype/styles dist/client/libs/prodotype/styles/
Building /usr/local/silex-for-hosting-company/node_modules/silex/src/prodotype/components to /usr/local/silex-for-hosting-company/node_modules/silex/dist/client/libs/prodotype/components in current dir: /usr/local/silex-for-hosting-company/node_modules/silex
Building template aligned-container
Building template animated-container
Building template autosize-section
Building template form
Building template hero-center
Building template hero-scroll-bottom
Building template hero-section
Building template jekyll-collection-item
Building template json-box
Building template map
Building template share
Building template skill-bars
Building template slideshow
Building template test
Building template test2
writing /usr/local/silex-for-hosting-company/node_modules/silex/dist/client/libs/prodotype/components/components.json
Building /usr/local/silex-for-hosting-company/node_modules/silex/src/prodotype/styles to /usr/local/silex-for-hosting-company/node_modules/silex/dist/client/libs/prodotype/styles in current dir: /usr/local/silex-for-hosting-company/node_modules/silex
Building template text
writing /usr/local/silex-for-hosting-company/node_modules/silex/dist/client/libs/prodotype/styles/components.json
-bash-4.2$ npm start
***@***.*** start /usr/local/silex-for-hosting-company
node index.js
Silex starts with backward compat version [ 2, 2, 8 ] and front end version [ 2, 8 ]
/usr/local/silex-for-hosting-company/node_modules/silex/node_modules
/usr/local/silex-for-hosting-company/custom-provider.js:24
module.exports.prototype.getVhosts = async function(session) {
^^^^^^^^
SyntaxError: Unexpected token function
at createScript (vm.js:56:10)
at Object.runInThisContext (vm.js:97:10)
at Module._compile (module.js:549:28)
at Object.Module._extensions..js (module.js:586:10)
at Module.load (module.js:494:32)
at tryModuleLoad (module.js:453:12)
at Function.Module._load (module.js:445:3)
at Module.require (module.js:504:17)
at require (internal/module.js:20:19)
at Object.<anonymous> (/usr/local/silex-for-hosting-company/index.js:5:24)
at Module._compile (module.js:577:32)
at Object.Module._extensions..js (module.js:586:10)
at Module.load (module.js:494:32)
at tryModuleLoad (module.js:453:12)
at Function.Module._load (module.js:445:3)
at Module.runMain (module.js:611:10)
npm ERR! Linux 4.20.0-1.el7.elrepo.x86_64
npm ERR! argv "/usr/bin/node" "/bin/npm" "start"
npm ERR! node v6.16.0
npm ERR! npm v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! silex-for-hosting-company@1.0.0 start: `node index.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the silex-for-hosting-company@1.0.0 start script 'node index.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the silex-for-hosting-company package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node index.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs silex-for-hosting-company
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls silex-for-hosting-company
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR! /usr/local/silex-for-hosting-company/npm-debug.log
-bash-4.2$
|
|
This is certainly a problem of node version. Look at the needed version in the file .nvmWe should fix the docs and add that everywhere-------- Original Message --------Subject: Re: [silexlabs/Silex] Publish to a hosting directly (#691)From: Glen Eustace To: silexlabs/Silex CC: Alex Hoyau ,Mention
On 9/03/2019, at 1:28 PM, Alex Hoyau ***@***.***> wrote:
Glen could you make it?
Can you try and see if the project works without your modifications?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#691 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIAqGDYgJjgbhN7noo0Mnvx_cNbRX2laks5vUwAWgaJpZM4SJatK>.
I created a second clone of the repo. And get this
-bash-4.2$ npm run build
***@***.*** build /usr/local/silex-for-hosting-company
npm run build:templates && npm run build:components
***@***.*** build:templates /usr/local/silex-for-hosting-company
cp -r templates/* `node_modules`/silex-templates/
***@***.*** build:components /usr/local/silex-for-hosting-company
cp components/* `node_modules`/silex/src/prodotype/components/ && cd `node_modules`/silex/ && npm run build:prodotype
***@***.*** build:prodotype /usr/local/silex-for-hosting-company/node_modules/silex
mkdir -p dist/client/libs/prodotype/components && prodotype src/prodotype/components dist/client/libs/prodotype/components/ && prodotype src/prodotype/styles dist/client/libs/prodotype/styles/
Building /usr/local/silex-for-hosting-company/node_modules/silex/src/prodotype/components to /usr/local/silex-for-hosting-company/node_modules/silex/dist/client/libs/prodotype/components in current dir: /usr/local/silex-for-hosting-company/node_modules/silex
Building template aligned-container
Building template animated-container
Building template autosize-section
Building template form
Building template hero-center
Building template hero-scroll-bottom
Building template hero-section
Building template jekyll-collection-item
Building template json-box
Building template map
Building template share
Building template skill-bars
Building template slideshow
Building template test
Building template test2
writing /usr/local/silex-for-hosting-company/node_modules/silex/dist/client/libs/prodotype/components/components.json
Building /usr/local/silex-for-hosting-company/node_modules/silex/src/prodotype/styles to /usr/local/silex-for-hosting-company/node_modules/silex/dist/client/libs/prodotype/styles in current dir: /usr/local/silex-for-hosting-company/node_modules/silex
Building template text
writing /usr/local/silex-for-hosting-company/node_modules/silex/dist/client/libs/prodotype/styles/components.json
-bash-4.2$ npm start
***@***.*** start /usr/local/silex-for-hosting-company
node index.js
Silex starts with backward compat version [ 2, 2, 8 ] and front end version [ 2, 8 ]
/usr/local/silex-for-hosting-company/node_modules/silex/node_modules
/usr/local/silex-for-hosting-company/custom-provider.js:24
module.exports.prototype.getVhosts = async function(session) {
^^^^^^^^
SyntaxError: Unexpected token function
at createScript (vm.js:56:10)
at Object.runInThisContext (vm.js:97:10)
at Module._compile (module.js:549:28)
at Object.Module._extensions..js (module.js:586:10)
at Module.load (module.js:494:32)
at tryModuleLoad (module.js:453:12)
at Function.Module._load (module.js:445:3)
at Module.require (module.js:504:17)
at require (internal/module.js:20:19)
at Object.<anonymous> (/usr/local/silex-for-hosting-company/index.js:5:24)
at Module._compile (module.js:577:32)
at Object.Module._extensions..js (module.js:586:10)
at Module.load (module.js:494:32)
at tryModuleLoad (module.js:453:12)
at Function.Module._load (module.js:445:3)
at Module.runMain (module.js:611:10)
npm ERR! Linux 4.20.0-1.el7.elrepo.x86_64
npm ERR! argv "/usr/bin/node" "/bin/npm" "start"
npm ERR! node v6.16.0
npm ERR! npm v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! silex-for-hosting-company@1.0.0 start: `node index.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the silex-for-hosting-company@1.0.0 start script 'node index.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the silex-for-hosting-company package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node index.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs silex-for-hosting-company
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls silex-for-hosting-company
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR! /usr/local/silex-for-hosting-company/npm-debug.log
-bash-4.2$
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/silexlabs/Silex","title":"silexlabs/Silex","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/silexlabs/Silex"}},"updates":{"snippets":[{"icon":"PERSON","message":"@godzone in #691: \n\n\u003e On 9/03/2019, at 1:28 PM, Alex Hoyau \u003cnotifications@github.com\u003e wrote:\n\u003e \n\u003e Glen could you make it?\n\u003e Can you try and see if the project works without your modifications?\n\u003e \n\u003e —\n\u003e You are receiving this because you were mentioned.\n\u003e Reply to this email directly, view it on GitHub \u003chttps://github.com/silexlabs/Silex/issues/691#issuecomment-471124243\u003e, or mute the thread \u003chttps://github.com/notifications/unsubscribe-auth/AIAqGDYgJjgbhN7noo0Mnvx_cNbRX2laks5vUwAWgaJpZM4SJatK\u003e.\n\u003e \nI created a second clone of the repo. And get this\n\n-bash-4.2$ npm run build\n\n\u003e silex-for-hosting-company@1.0.0 build /usr/local/silex-for-hosting-company\n\u003e npm run build:templates \u0026\u0026 npm run build:components\n\n\n\u003e silex-for-hosting-company@1.0.0 build:templates /usr/local/silex-for-hosting-company\n\u003e cp -r templates/* `node_modules`/silex-templates/\n\n\n\u003e silex-for-hosting-company@1.0.0 build:components /usr/local/silex-for-hosting-company\n\u003e cp components/* `node_modules`/silex/src/prodotype/components/ \u0026\u0026 cd `node_modules`/silex/ \u0026\u0026 npm run build:prodotype\n\n\n\u003e silex@2.4.0 build:prodotype /usr/local/silex-for-hosting-company/node_modules/silex\n\u003e mkdir -p dist/client/libs/prodotype/components \u0026\u0026 prodotype src/prodotype/components dist/client/libs/prodotype/components/ \u0026\u0026 prodotype src/prodotype/styles dist/client/libs/prodotype/styles/\n\nBuilding /usr/local/silex-for-hosting-company/node_modules/silex/src/prodotype/components to /usr/local/silex-for-hosting-company/node_modules/silex/dist/client/libs/prodotype/components in current dir: /usr/local/silex-for-hosting-company/node_modules/silex\nBuilding template aligned-container\nBuilding template animated-container\nBuilding template autosize-section\nBuilding template form\nBuilding template hero-center\nBuilding template hero-scroll-bottom\nBuilding template hero-section\nBuilding template jekyll-collection-item\nBuilding template json-box\nBuilding template map\nBuilding template share\nBuilding template skill-bars\nBuilding template slideshow\nBuilding template test\nBuilding template test2\nwriting /usr/local/silex-for-hosting-company/node_modules/silex/dist/client/libs/prodotype/components/components.json\nBuilding /usr/local/silex-for-hosting-company/node_modules/silex/src/prodotype/styles to /usr/local/silex-for-hosting-company/node_modules/silex/dist/client/libs/prodotype/styles in current dir: /usr/local/silex-for-hosting-company/node_modules/silex\nBuilding template text\nwriting /usr/local/silex-for-hosting-company/node_modules/silex/dist/client/libs/prodotype/styles/components.json\n-bash-4.2$ npm start\n\n\u003e silex-for-hosting-company@1.0.0 start /usr/local/silex-for-hosting-company\n\u003e node index.js\n\nSilex starts with backward compat version [ 2, 2, 8 ] and front end version [ 2, 8 ]\n/usr/local/silex-for-hosting-company/node_modules/silex/node_modules\n/usr/local/silex-for-hosting-company/custom-provider.js:24\nmodule.exports.prototype.getVhosts = async function(session) {\n ^^^^^^^^\n\nSyntaxError: Unexpected token function\n at createScript (vm.js:56:10)\n at Object.runInThisContext (vm.js:97:10)\n at Module._compile (module.js:549:28)\n at Object.Module._extensions..js (module.js:586:10)\n at Module.load (module.js:494:32)\n at tryModuleLoad (module.js:453:12)\n at Function.Module._load (module.js:445:3)\n at Module.require (module.js:504:17)\n at require (internal/module.js:20:19)\n at Object.\u003canonymous\u003e (/usr/local/silex-for-hosting-company/index.js:5:24)\n at Module._compile (module.js:577:32)\n at Object.Module._extensions..js (module.js:586:10)\n at Module.load (module.js:494:32)\n at tryModuleLoad (module.js:453:12)\n at Function.Module._load (module.js:445:3)\n at Module.runMain (module.js:611:10)\n\nnpm ERR! Linux 4.20.0-1.el7.elrepo.x86_64\nnpm ERR! argv \"/usr/bin/node\" \"/bin/npm\" \"start\"\nnpm ERR! node v6.16.0\nnpm ERR! npm v3.10.10\nnpm ERR! code ELIFECYCLE\nnpm ERR! silex-for-hosting-company@1.0.0 start: `node index.js`\nnpm ERR! Exit status 1\nnpm ERR! \nnpm ERR! Failed at the silex-for-hosting-company@1.0.0 start script 'node index.js'.\nnpm ERR! Make sure you have the latest version of node.js and npm installed.\nnpm ERR! If you do, this is most likely a problem with the silex-for-hosting-company package,\nnpm ERR! not with npm itself.\nnpm ERR! Tell the author that this fails on your system:\nnpm ERR! node index.js\nnpm ERR! You can get information on how to open an issue for this project with:\nnpm ERR! npm bugs silex-for-hosting-company\nnpm ERR! Or if that isn't available, you can get their info via:\nnpm ERR! npm owner ls silex-for-hosting-company\nnpm ERR! There is likely additional logging output above.\n\nnpm ERR! Please include the following file with any support request:\nnpm ERR! /usr/local/silex-for-hosting-company/npm-debug.log\n-bash-4.2$ \n\n"}],"action":{"name":"View Issue","url":"#691 (comment)"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "#691 (comment)",
"url": "#691 (comment)",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
|
On 9/03/2019, at 4:04 PM, Alex Hoyau ***@***.***> wrote:
This is certainly a problem of node version. Look at the needed version in the file .nvmWe should fix the docs and add that everywhere
I have update node, but it went to 8.15, not 8.10
Now I get a different error when attempting the build.
***@***.*** build:sass /usr/local/silex-for-hosting-company/node_modules/cloud-explorer
node-sass --include-path `node_modules font-awesome` --include-path `node_modules npm-font-open-sans` src/sass/style.scss dist/style.css
/usr/local/silex-for-hosting-company/node_modules/node-sass/lib/binding.js:13
throw new Error(errors.unsupportedEnvironment());
^
Error: Node Sass does not yet support your current environment: Linux 64-bit with Unsupported runtime (57)
For more information on which environments are supported please see:
https://github.com/sass/node-sass/releases/tag/v3.13.1
at module.exports (/usr/local/silex-for-hosting-company/node_modules/node-sass/lib/binding.js:13:13)
at Object.<anonymous> (/usr/local/silex-for-hosting-company/node_modules/node-sass/lib/index.js:
I am not a node user but if node stuff is this sensitive to versions, looking after Silex is going to be a real pain.
|
|
did you delete "node_modules" and do "npm install" again? |
|
On 10/03/2019, at 1:17 PM, Alex Hoyau ***@***.***> wrote:
did you delete "node_modules" and do "npm install" again?
because i just tried with 8.15 and it works
It was a fresh install from my fork, should I have cloned your repo again instead ?
|
|
Simply be sure to have the right nodejs version, delete node_modules and package-lock.json and do npm I then npm start-------- Original Message --------Subject: Re: [silexlabs/Silex] Publish to a hosting directly (#691)From: Glen Eustace To: silexlabs/Silex CC: Alex Hoyau ,Mention
On 10/03/2019, at 1:17 PM, Alex Hoyau ***@***.***> wrote:
did you delete "node_modules" and do "npm install" again?
because i just tried with 8.15 and it works
It was a fresh install from my fork, should I have cloned your repo again instead ?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/silexlabs/Silex","title":"silexlabs/Silex","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/silexlabs/Silex"}},"updates":{"snippets":[{"icon":"PERSON","message":"@godzone in #691: \n\n\u003e On 10/03/2019, at 1:17 PM, Alex Hoyau \u003cnotifications@github.com\u003e wrote:\n\u003e \n\u003e did you delete \"node_modules\" and do \"npm install\" again?\n\u003e because i just tried with 8.15 and it works\n\nIt was a fresh install from my fork, should I have cloned your repo again instead ?\n\n"}],"action":{"name":"View Issue","url":"#691 (comment)"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "#691 (comment)",
"url": "#691 (comment)",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
|
And yes 8.15 is ok
|
|
On 11/03/2019, at 4:43 AM, Alex Hoyau ***@***.***> wrote:
And yes 8.15 is ok
OK< that all worked. I can now have another look at my code.
Thanks. You have been most helpful (as usual :-)
Glen
|
|
It seems much of the Publishing process is hidden or driven from the client side. What I would like is to simply publish back into the users home folder, potentially creating another folder but not by default or mandatory. All the stuff to do with domains is pretty much irrelevant to my situation. I can’t seem to workout what is happening, the publish function creates a ‘Website’ folder which I dont want it too.
As always, any assistance appreciated.
Glen
|
|
Hi |
|
Or maybe one more step after 1- could be "let the user choose a directory with ~/ as root in the file explorer" Or "display a list of accounts in a drop-down list" |
|
On 25/03/2019, at 8:58 AM, Alex Hoyau ***@***.***> wrote:
Or maybe one more step after 1- could be "let the user choose a directory with ~/ as root in the file explorer"
Or "display a list of accounts in a drop-down list"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#691 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIAqGFS_6x1gyDsnWhvUVqfK5We4tTv3ks5vZ9jTgaJpZM4SJatK>.
From your comments I think you are now on the same page as me.
What I would like to see
1. Click Publish
2. Bring up file explorer with the default being the same folder that the ‘editable.html’ file was saved to. This means it is the users choice how they structure their site. All files could be in the root, the source could be in a folder and the published site in the root etc etc.
3. Publish
4. A possible acknowledgement. I would suggest this message is constructed in the customer-provider code so that it can be set to anything. It might just be “OK” or “Thank you …. etc” or Some text including the URL
I have noted that if I try to open an editable.html that I created prior to this version of silex, I don’t get any errors just a blank canvas. I had thought some conversion might have occurred to update the files content.
|
|
Ok this is possible by changing the config and hosting provider, I'll explain soon how The websites made with a previous version are upgraded and the user is warned. Nothing is permanent until the website is saved. This is handled by the BackwardCompat class |
|
Ok, is this how you want it? 1st click on publish:
2nd click on publish:
This is what I changed to the custom hosting provider code: |
|
explanation for these changes:
|
|
On 26/03/2019, at 9:14 AM, Alex Hoyau ***@***.***> wrote:
explanation for these changes:
skipFolderSelection: false=> let the user choose a folder (root is decided by the custom unifile service)
afterPublishMessage => custom message for after publication
skipDomainSelection: true => do not ask for a domain name
skipVhostSelection: true => do not ask the user to shoose a "vhost" or "account" or what you want in a dropdown list
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#691 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIAqGK3IdSIKWEvj3qOqNNPXANOEugVoks5vaS44gaJpZM4SJatK>.
We are getting very close :-)
The only change I needed was to set skipFolderSelection I had it set to true.
As always, I have got busy on something else but at least I can get the entire workflow now working and can make, hopefully, constructive comments on how it may be improved (if that is appropriate) when I get back to this project, hopefully in a few days.
Glen.
|
|
Great !
Constructive comments and even feature requests are indeed appropriate and even appreciated :)
|
|
OK, my other project, trying to update a Joomla 2.5 site to 3.x, when I know nothing about Joomla, has just gotten too hard so I am putting it aside for a time.
Some comments
1. Dialogue has ‘YOU ARE NOTE LOOGED IN’, NOTE should be NOT
2, Finding the ’Logout’ link is not straight forward. Could it possibly be a ‘button’ at the top along with the Create folder and Reload.
3. I would like to provide my own message for ‘Please visit your site’ Can I do that ?
4. Not sure how, but silex recreated the ‘Website’ folder at some point.
I need to pretend to be a customer and work through from beginning to end. I definitely need to provide some instructions I think to help get people started.
Glen.
|
|
4. Not sure how, but silex recreated the ‘Website’ folder at some point.
I need to pretend to be a customer and work through from beginning to end. I definitely need to provide some instructions I think to help get people started.
Glen.
There definitely seems to be an issue with Silex creating a Website folder and then trying to publish into it even though I tried selecting the root by selecting the ‘custom-service’ folder.
|
|
Here in your code (comes from mine) it is creating the folder named Website when you login And here it is forcing the publish process to publish in Website |
|
On 26/03/2019, at 4:22 PM, Alex Hoyau ***@***.***> wrote:
Here in your code (comes from mine) it is creating the folder named Website when you login
https://github.com/godzone/silex-for-hosting-company/blob/master/custom-service.js#L55 <https://github.com/godzone/silex-for-hosting-company/blob/master/custom-service.js#L55>
And here it is forcing the publish process to publish in Website
https://github.com/godzone/silex-for-hosting-company/blob/master/custom-provider.js#L32 <https://github.com/godzone/silex-for-hosting-company/blob/master/custom-provider.js#L32>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#691 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIAqGDhvN9378ERPwN9SrtZudrhjX8EMks5vaZJdgaJpZM4SJatK>.
None of that code exists in my code, I’ll need to push it to GitHub so you can see what I now have.
Glen.
|
![https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open](https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Silex publication is a process to clean up and optimize the site, then it put the result in the target folder chosen in the settings.
We should be able to choose a hosting company directly in silex and publish to a domain name instead of a folder, e.g. choose Gandi.net then one of the user's domain name then publish.
There is also @pierreozoux 's indie hosters, Github pages, Heroku, and others from the Jekyll deployment methods
It would be smart I guess to create a separate project for this
Providers
Features offered by providers
The text was updated successfully, but these errors were encountered: