Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 templates #10

Merged
merged 1 commit into from
Nov 22, 2015
Merged

Add 2 templates #10

merged 1 commit into from
Nov 22, 2015

Conversation

Fluoflo
Copy link
Contributor

@Fluoflo Fluoflo commented Nov 21, 2015

No description provided.

@lexoyo
Copy link
Member

lexoyo commented Nov 22, 2015

hey @Fluoflo thank you !
I need you to do 2 things before I can accept the pull request:

  • add a screenshot, with the same name and size (678x336) as the other templates, like this one - this is because the templates appear on silex website
  • rename your index.html to editable.html and publish your website as explained here so that there is a "clean" index.html beside your editable.html (if this is too confusing, I guess you could skip this step)

@Fluoflo
Copy link
Contributor Author

Fluoflo commented Nov 22, 2015

Committed screenshots and change idnex -> editable but I'm not sure where the "clean" indexes come from

@lexoyo
Copy link
Member

lexoyo commented Nov 22, 2015

You are supposed to open file > settings > publication settings, and select a folder as shown here
silexlabs/Silex#238

Select your root folder, where your editable.html is

@Fluoflo
Copy link
Contributor Author

Fluoflo commented Nov 22, 2015

Ok, got it. PR squashed & ready to merge!

lexoyo added a commit that referenced this pull request Nov 22, 2015
@lexoyo lexoyo merged commit ba7a6b1 into silexlabs:gh-pages Nov 22, 2015
singchan added a commit that referenced this pull request Jan 25, 2017
singchan added a commit that referenced this pull request Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants