Skip to content

Commit

Permalink
only deploy to prod if integration tests pass or fail, if they are ca…
Browse files Browse the repository at this point in the history
…ncelled in the case of a failure further up the line we don't want to deploy.
  • Loading branch information
hahn-kev committed Nov 20, 2023
1 parent 1ffca46 commit c761541
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/release-pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ jobs:
name: Deploy Production
uses: ./.github/workflows/deploy.yaml
needs: [ integration-tests, set-version ]
if: always()
# we want to allow deployment even if some tests fail because they are currently flaky
if: ${{ needs.integration-tests.result == 'success' || needs.integration-tests.result == 'failure' }}
secrets: inherit
with:
version: ${{ needs.set-version.outputs.version }}
Expand Down

0 comments on commit c761541

Please sign in to comment.