Ensure tests run on ci #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCM Tests 8 files 8 suites 1m 34s ⏱️ Results for commit 513fdda. ♻️ This comment has been updated with latest results. |
…download Test results artifacts
jasonleenaylor
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @hahn-kev)
* The mismatch brought in a newer version of assemblies after the non-test assemblies were built causing test failures
…as 0. Added a test for this case.
jasonleenaylor
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Reviewed 2 of 3 files at r3, all commit messages.
Reviewable status: 6 of 7 files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently no tests are being found and run on CI, however there's no errors. I suspect this has been happening since bc9c0da as that's when the test adapter version changed.
I've also included test reporting in CI so we will better catch when tests aren't running. It turns out the flag
RunConfiguration.FailWhenNoTestsFound=trueonly works for the vstest adapter, which we're not using.This change is