Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Optimize string parsing" #27

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Revert "Optimize string parsing" #27

merged 1 commit into from
Jun 24, 2019

Conversation

Licenser
Copy link
Member

This reverts commit 0ff4ece.

This fixes a seg-fault that was introduced with 0.1.14. The reason for that segfault is that it introduced an issue of us reading after the input data od possibly crossing page boundaries.

Better handling of relocated data might solve that but rust could get into the way here. Worth an investigation later.

@Licenser Licenser merged commit 32fcd77 into master Jun 24, 2019
@Licenser Licenser deleted the fix-segfault branch July 30, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant