Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript definition #38

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Add TypeScript definition #38

merged 2 commits into from
Apr 11, 2019

Conversation

BendingBender
Copy link
Contributor

No description provided.

@sindresorhus
Copy link
Owner

You need to mark this PR as "Require Node.js 8" and take it out of .travis.yml.

sindresorhus
sindresorhus reviewed Apr 10, 2019
View reviewed changes
index.d.ts
/**
Keys or regex of keys to exclude. Takes precedence over `includes`.
*/
excludes?: ReadonlyArray<string | RegExp>;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it will be a major release anyway, you can change to readonly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we want to wrap complex types in Array/ReadonlyArray?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So readonly Array<string | RegExp> doesn't work?

@BendingBender
Copy link
Contributor Author

You need to mark this PR as "Require Node.js 8" and take it out of .travis.yml.

I thought that we leave Node.js 6 for packages that are already at this level. Do you want to move to Node.js 8 even for those packages?

@sindresorhus
Copy link
Owner

I thought that we leave Node.js 6 for packages that are already at this level. Do you want to move to Node.js 8 even for those packages?

Yes, but you already did. You cannot use object spread in Node.js 6: https://github.com/sindresorhus/dargs/pull/38/files#diff-168726dbe96b3ce427e7fedce31bb0bcR14 Or Object.entries(): https://github.com/sindresorhus/dargs/pull/38/files#diff-168726dbe96b3ce427e7fedce31bb0bcR42 Probably best to just revert those two changes then.

@sindresorhus sindresorhus merged commit 24f4dd1 into sindresorhus:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BendingBender @sindresorhus