Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add array-join-separator rule #1284

Merged
merged 7 commits into from
May 18, 2021
Merged

Add array-join-separator rule #1284

merged 7 commits into from
May 18, 2021

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented May 18, 2021

Fixes #1246

sindresorhus
sindresorhus requested changes May 18, 2021
View reviewed changes
docs/rules/array-join-separator.md Outdated Show resolved Hide resolved
docs/rules/array-join-separator.md Outdated Show resolved Hide resolved
fisker and others added 2 commits May 18, 2021 16:39
@fisker @sindresorhus
Apply suggestions from code review
c7ea1fa 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@fisker
Update description
9129587
@sindresorhus sindresorhus merged commit 36e7103 into sindresorhus:main May 18, 2021
@fisker fisker deleted the array-join-separator branch May 18, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: array-join-separator
2 participants
@fisker @sindresorhus