Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 upgrade (usage of =>) breaks easy browserify support #78

Closed
shamasis opened this issue Mar 21, 2017 · 1 comment
Closed

v4 upgrade (usage of =>) breaks easy browserify support #78

shamasis opened this issue Mar 21, 2017 · 1 comment

Comments

@shamasis
Copy link

shamasis commented Mar 21, 2017

Hi,

The v4 release does a great job to move on to using => in code. However, simple browserify fails now. I understand that browserify of this module is odd, but we do it. :-)

Simply adding babel transform in package will make this way way easier for consumption. The other alternative for browserify consumers is to use complicated logic to specifically transform this module.

"browserify": {
    "transform": [["babelify", { "presets": ["latest"] }]]
  }

is all what we mere mortals need @sindresorhus

@sindresorhus
Copy link
Owner

As I commented, duplicate of #70. I'm not interested in doing anything special for the browser. Please read: sindresorhus/ama#446 (comment) Sorry.

You could always just stay on v3. It has the most common formats you'll need.

arturi added a commit to transloadit/uppy that referenced this issue Jun 14, 2017
we inline file-type module, as opposed to using the NPM version,
because of this sindresorhus/file-type#78 and
sindresorhus/copy-text-to-clipboard#5
Repository owner deleted a comment from pconerly Oct 21, 2017
Repository owner deleted a comment from philipstanislaus Oct 21, 2017
Repository owner locked and limited conversation to collaborators Oct 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants