Fix: unit test

sinonjs · Jun 20, 2017 · 2c88a7e · 2c88a7e
1 parent ae274c3
commit 2c88a7e
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 20 deletions.
diff --git a/test/issues/issues-test.js b/test/issues/issues-test.js
@@ -2,6 +2,7 @@
 
 var referee = require("referee");
 var sinon = require("../../lib/sinon");
+var sinonSandbox = require("../../lib/sinon/sandbox");
 var configureLogError = require("../../lib/sinon/util/core/log_error.js");
 var assert = referee.assert;
 var refute = referee.refute;
@@ -248,4 +249,24 @@ describe("issues", function () {
             });
         });
     });
+
+    if (typeof window !== "undefined") {
+        describe("#1456", function () {
+            var sandbox;
+
+            beforeEach(function () {
+                sandbox = sinonSandbox.create();
+            });
+
+            afterEach(function () {
+                sandbox.restore();
+            });
+
+            it("stub window innerHeight", function () {
+                sandbox.stub(window, "innerHeight").value(111);
+
+                assert.equals(window.innerHeight, 111);
+            });
+        });
+    }
 });
diff --git a/test/sandbox-test.js b/test/sandbox-test.js
@@ -626,24 +626,4 @@ describe("sinonSandbox", function () {
             assert.equals(object.prop, "bla");
         });
     });
-
-    if (typeof window !== "undefined") {
-        describe("window properties", function () {
-            var sandbox;
-
-            beforeEach(function () {
-                sandbox = sinonSandbox.create();
-            });
-
-            afterEach(function () {
-                sandbox.restore();
-            });
-
-            it("stub window innerHeight", function () {
-                sandbox.stub(window, "innerHeight").value(111);
-
-                assert.equals(window.innerHeight, 111);
-            });
-        });
-    }
 });
diff --git a/test/stub-test.js b/test/stub-test.js
@@ -2672,5 +2672,18 @@ describe("stub", function () {
 
             assert.equals(myFunc.prop, "rawString");
         });
+
+        it("allows stubbing object props with configurable false", function () {
+            var myObj = {};
+            Object.defineProperty(myObj, "prop", {
+                configurable: false,
+                enumerable: true,
+                writable: true,
+                value: "static"
+            });
+
+            createStub(myObj, "prop").value("newString");
+            assert.equals(myObj.prop, "newString");
+        });
     });
 });