Avoid running test for #1456 on Safari

[fatso83]

Purpose

This avoids breaking the build by avoiding running the breaking test on Safari. See background in #1462.

Background (Problem in detail) - optional

Safari throws an error when trying to configure properties on window that are not configurable. AFAIK this is not a problem Sinon can solve: if the prop cannot be stubbed, then we shouldn't suppress the error or avoid trying to stub it.

How to verify - mandatory

1. Check out this branch
2. npm install
3. Configure Sauce Labs:

export SAUCE_USERNAME=sinon-sauce-name
export SAUCE_ACCESS_KEY=abcd3-12345-...

4. npm run test-cloud

BTW, the code is not so nice ATM. I was just so annoyed by the errors from Travis, so just needed to put a fix out there ... Not totally sure where to put the runtime detection of how this breaks and I am not so sure about how I skip the test. Maybe a simple return would suffice?

[coveralls]

Coverage remained the same at 94.998% when pulling 286b0a2 on fatso83:fix-safari-breaking into 1108117 on sinonjs:master.

[coveralls]

Coverage remained the same at 94.998% when pulling 54f67c1 on fatso83:fix-safari-breaking into 1108117 on sinonjs:master.

[fearphage]

Any reason not to do this all inline instead of setting a single-use variable?

Also if you do the check in the beforeEach, you can call this.skip(); to skip all the related tests.

[fatso83]

nope, it was a quick and dirty thing, and I wasn't aware of the this.skip thing.

[mroderick]

@fatso83 will you make a slow and clean version, or shall we merge this one?

[fatso83]

ah, sorry, I totally forgot. Was offline and on holiday for a week.

[coveralls]

Coverage remained the same at 95.002% when pulling 3642905 on fatso83:fix-safari-breaking into 717ebf7 on sinonjs:master.

[fatso83]

I think the issues have been addressed, @fearphage. I started moving the test for error throwing to beforeEach, but it was a lot of detail that needed commenting, so opted to extracting it to a named function instead to document the intent.

[coveralls]

Coverage remained the same at 95.002% when pulling bb2d585 on fatso83:fix-safari-breaking into 717ebf7 on sinonjs:master.

[coveralls]

Coverage remained the same at 95.002% when pulling 24d15f2 on fatso83:fix-safari-breaking into 717ebf7 on sinonjs:master.

[mroderick]

👍